[typechecker] [test] cleanup

Author: Suyash Srijan

lib/Sema/TypeCheckPattern.cpp

@@ -1395,15 +1395,14 @@ bool TypeChecker::coercePatternToType(Pattern *&P, TypeResolution resolution,
             goto recur;
           }
 
-          // If we have an optional type let's try to see if the case
-          // exists in its base type and create a new pattern which contains
-          // the enum case.
+          // If we have an optional type, let's try to see if the case
+          // exists in its base type and if it does then synthesize an
+          // OptionalSomePattern that wraps the case.
           if (auto baseType = type->getOptionalObjectType()) {
             if (lookupEnumMemberElement(*this, dc, baseType, EEP->getName(),
                                         EEP->getLoc())) {
               P = new (Context)
-                  OptionalSomePattern(EEP, EEP->getEndLoc(), true);
-              P->setImplicit();
+                  OptionalSomePattern(EEP, EEP->getEndLoc(), /*implicit*/true);
               return coercePatternToType(P, resolution, type, options);
             } else {
               diagnose(EEP->getLoc(),

test/Constraints/patterns.swift

@@ -420,4 +420,4 @@ switch sr7799 {
  case .bar?: break // Ok
  case .baz: break // Ok
  default: break
-}
+}

test/SILGen/enum.swift

@@ -252,4 +252,4 @@ func sr7799(bar: SR7799?) {
   case .two?: print("two")
   default: print("default")
   }
-}
+}