Skip to content

Commit 5090203

Browse files
authored
Merge pull request swiftlang#28958 from compnerd/deprecated
build: remove workaround for CMake 3.4.0
2 parents d2681c0 + 14ecd9f commit 5090203

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

utils/build-script-impl

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -555,26 +555,12 @@ function set_build_options_for_host() {
555555
-DLLVM_ENABLE_MODULES:BOOL="$(true_false ${LLVM_ENABLE_MODULES})"
556556
)
557557
if [[ $(is_llvm_lto_enabled) == "TRUE" ]]; then
558-
if [[ $(cmake_needs_to_specify_standard_computed_defaults) == "TRUE" ]]; then
559-
llvm_cmake_options+=(
560-
"-DCMAKE_C_STANDARD_COMPUTED_DEFAULT=AppleClang"
561-
"-DCMAKE_CXX_STANDARD_COMPUTED_DEFAULT=AppleClang"
562-
)
563-
fi
564-
565558
llvm_cmake_options+=(
566559
"-DLLVM_PARALLEL_LINK_JOBS=${LLVM_NUM_PARALLEL_LTO_LINK_JOBS}"
567560
)
568561
fi
569562

570563
if [[ $(is_swift_lto_enabled) == "TRUE" ]]; then
571-
if [[ $(cmake_needs_to_specify_standard_computed_defaults) = "TRUE" ]]; then
572-
swift_cmake_options+=(
573-
"-DCMAKE_C_STANDARD_COMPUTED_DEFAULT=AppleClang"
574-
"-DCMAKE_CXX_STANDARD_COMPUTED_DEFAULT=AppleClang"
575-
)
576-
fi
577-
578564
llvm_cmake_options+=(
579565
-DLLVM_ENABLE_MODULE_DEBUGGING:BOOL=NO
580566
)
@@ -896,14 +882,6 @@ function cmake_version() {
896882
"${CMAKE}" --version | grep "cmake version" | cut -f 3 -d " "
897883
}
898884

899-
function cmake_needs_to_specify_standard_computed_defaults() {
900-
if [[ $(cmake_version) = "3.4.0" ]]; then
901-
echo "TRUE"
902-
else
903-
echo "FALSE"
904-
fi
905-
}
906-
907885
# Sanitize the list of cross-compilation targets.
908886
#
909887
# In the Build/Host/Target paradigm:

0 commit comments

Comments
 (0)