Merge pull request swiftlang#20382 from moiseev/runtime-buffers

[stdlib] Internalize _Buffer32 and _Buffer72

Author: moiseev

stdlib/public/core/Integers.swift

@@ -1430,8 +1430,6 @@ extension BinaryInteger {
 //===----------------------------------------------------------------------===//
 
 extension BinaryInteger {
-  @usableFromInline
-  @_transparent
   internal func _description(radix: Int, uppercase: Bool) -> String {
     _precondition(2...36 ~= radix, "Radix must be between 2 and 36")
 

stdlib/public/core/Runtime.swift.gyb

@@ -170,17 +170,12 @@ internal func _swift_stdlib_atomicFetchAddInt(
 //===----------------------------------------------------------------------===//
 
 /// A 32 byte buffer.
-@_fixed_layout // FIXME(sil-serialize-all)
-@usableFromInline // FIXME(sil-serialize-all)
 internal struct _Buffer32 {
-  @inlinable // FIXME(sil-serialize-all)
   internal init() {}
 % for i in range(32):
-  @usableFromInline // FIXME(sil-serialize-all)
   internal var _x${i}: UInt8 = 0
 % end
 
-  @inlinable // FIXME(sil-serialize-all)
   internal mutating func withBytes<Result>(
     _ body: (UnsafeMutablePointer<UInt8>) throws -> Result
   ) rethrows -> Result
@@ -192,17 +187,12 @@ internal struct _Buffer32 {
 }
 
 /// A 72 byte buffer.
-@_fixed_layout // FIXME(sil-serialize-all)
-@usableFromInline // FIXME(sil-serialize-all)
 internal struct _Buffer72 {
-  @inlinable // FIXME(sil-serialize-all)
   internal init() {}
 % for i in range(72):
-  @usableFromInline // FIXME(sil-serialize-all)
   internal var _x${i}: UInt8 = 0
 % end
 
-  @inlinable // FIXME(sil-serialize-all)
   internal mutating func withBytes<Result>(
     _ body: (UnsafeMutablePointer<UInt8>) throws -> Result
   ) rethrows -> Result
@@ -243,15 +233,13 @@ internal func _float${bits}ToString(
 
 % end
 
-@usableFromInline // FIXME(sil-serialize-all)
 @_silgen_name("swift_int64ToString")
 internal func _int64ToStringImpl(
   _ buffer: UnsafeMutablePointer<UTF8.CodeUnit>,
   _ bufferLength: UInt, _ value: Int64,
   _ radix: Int64, _ uppercase: Bool
 ) -> UInt
 
-@inlinable // FIXME(sil-serialize-all)
 internal func _int64ToString(
   _ value: Int64, radix: Int64 = 10, uppercase: Bool = false
 ) -> String {
@@ -274,14 +262,12 @@ internal func _int64ToString(
   }
 }
 
-@usableFromInline // FIXME(sil-serialize-all)
 @_silgen_name("swift_uint64ToString")
 internal func _uint64ToStringImpl(
   _ buffer: UnsafeMutablePointer<UTF8.CodeUnit>,
   _ bufferLength: UInt, _ value: UInt64, _ radix: Int64, _ uppercase: Bool
 ) -> UInt
 
-@inlinable // FIXME(sil-serialize-all)
 public // @testable
 func _uint64ToString(
     _ value: UInt64, radix: Int64 = 10, uppercase: Bool = false

stdlib/public/core/StringLegacy.swift

@@ -181,7 +181,6 @@ extension String {
   ///   - uppercase: Pass `true` to use uppercase letters to represent numerals
   ///     greater than 9, or `false` to use lowercase letters. The default is
   ///     `false`.
-  @inlinable // FIXME(sil-serialize-all)
   public init<T : BinaryInteger>(
     _ value: T, radix: Int = 10, uppercase: Bool = false
   ) {

test/api-digester/Outputs/stability-stdlib-abi.swift.expected

@@ -6,12 +6,15 @@ Func MutableCollection._partition(within:by:) has generic signature change from
 
 /* Removed Decls */
 Class _stdlib_AtomicInt has been removed
+Func BinaryInteger._description(radix:uppercase:) has been removed
 Func MutableCollection._heapSort(within:by:) has been removed
 Func MutableCollection._heapify(within:by:) has been removed
 Func MutableCollection._introSort(within:by:) has been removed
 Func MutableCollection._introSortImpl(within:by:depthLimit:) has been removed
 Func MutableCollection._siftDown(_:within:by:) has been removed
 Func MutableCollection._sort3(_:_:_:by:) has been removed
+Func _int64ToString(_:radix:uppercase:) has been removed
+Func _int64ToStringImpl(_:_:_:_:_:) has been removed
 Func _stdlib_atomicCompareExchangeStrongInt(object:expected:desired:) has been removed
 Func _stdlib_atomicCompareExchangeStrongInt32(object:expected:desired:) has been removed
 Func _stdlib_atomicCompareExchangeStrongInt64(object:expected:desired:) has been removed
@@ -45,7 +48,10 @@ Func _swift_stdlib_atomicStoreInt32(object:desired:) has been removed
 Func _swift_stdlib_atomicStoreInt64(object:desired:) has been removed
 Func _swift_stdlib_atomicStoreUInt32(object:desired:) has been removed
 Func _swift_stdlib_atomicStoreUInt64(object:desired:) has been removed
+Func _uint64ToStringImpl(_:_:_:_:_:) has been removed
 Protocol _HasherCore has been removed
+Struct _Buffer32 has been removed
+Struct _Buffer72 has been removed
 Struct _BufferingHasher has been removed
 Struct _HasherTailBuffer has been removed