Skip to content

Commit 56e58b4

Browse files
committed
build: remove duplicated parameter to _add_swift_host_library_single
1 parent f00cf8a commit 56e58b4

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

cmake/modules/AddSwift.cmake

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,6 @@ endfunction()
673673
# Usage:
674674
# _add_swift_host_library_single(
675675
# target
676-
# name
677676
# [SHARED]
678677
# [STATIC]
679678
# [SDK sdk]
@@ -683,9 +682,6 @@ endfunction()
683682
# source1 [source2 source3 ...])
684683
#
685684
# target
686-
# Name of the target (e.g., swiftParse-IOS-armv7).
687-
#
688-
# name
689685
# Name of the library (e.g., swiftParse).
690686
#
691687
# SHARED
@@ -708,7 +704,7 @@ endfunction()
708704
#
709705
# source1 ...
710706
# Sources to add into this library
711-
function(_add_swift_host_library_single target name)
707+
function(_add_swift_host_library_single target)
712708
set(SWIFTLIB_SINGLE_options
713709
SHARED
714710
STATIC)
@@ -804,11 +800,11 @@ function(_add_swift_host_library_single target name)
804800
# building on a non-DLL platform (not windows), create an imported target
805801
# for the library which created implicitly by the dll.
806802
add_custom_command_target(${target}_IMPORT_LIBRARY
807-
OUTPUT "${SWIFTLIB_DIR}/${SWIFTLIB_SINGLE_SUBDIR}/${name}.lib"
803+
OUTPUT "${SWIFTLIB_DIR}/${SWIFTLIB_SINGLE_SUBDIR}/${target}.lib"
808804
DEPENDS "${target}")
809805
add_library(${target}_IMPLIB SHARED IMPORTED GLOBAL)
810806
set_property(TARGET "${target}_IMPLIB" PROPERTY
811-
IMPORTED_LOCATION "${SWIFTLIB_DIR}/${SWIFTLIB_SINGLE_SUBDIR}/${name}.lib")
807+
IMPORTED_LOCATION "${SWIFTLIB_DIR}/${SWIFTLIB_SINGLE_SUBDIR}/${target}.lib")
812808
add_dependencies(${target}_IMPLIB ${${target}_IMPORT_LIBRARY})
813809
endif()
814810
set_property(TARGET "${target}" PROPERTY NO_SONAME ON)
@@ -849,7 +845,7 @@ function(_add_swift_host_library_single target name)
849845
set_target_properties(${target}
850846
PROPERTIES
851847
# Library name (without the variant information)
852-
OUTPUT_NAME ${name})
848+
OUTPUT_NAME ${target})
853849

854850
# Handle linking and dependencies.
855851
add_dependencies_multiple_targets(
@@ -1019,7 +1015,6 @@ function(add_swift_host_library name)
10191015
endif()
10201016

10211017
_add_swift_host_library_single(
1022-
${name}
10231018
${name}
10241019
${ASHL_SHARED_keyword}
10251020
${ASHL_STATIC_keyword}

0 commit comments

Comments
 (0)