Skip to content

Commit 5717d87

Browse files
committed
[build-script-impl] Add a comment explaining why an option isn't truly dead as per reviewers suggestion.
In the original revert, this option was used in two places and I added a comment only on the first one. This copies the comment onto the second usage of the option. Thanks to @edymtt and @compnerd for catching my careless error!
1 parent 9010c1b commit 5717d87

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

utils/build-script-impl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1808,6 +1808,12 @@ for host in "${ALL_HOSTS[@]}"; do
18081808
"${swift_cmake_options[@]}"
18091809
)
18101810

1811+
# NOTE: This is not a dead option! It is relied upon for certain
1812+
# bots/build-configs!
1813+
#
1814+
# TODO: In the future when we are always cross compiling and
1815+
# using Toolchain files, we should put this in either a
1816+
# toolchain file or a cmake cache.
18111817
if [[ "${BUILD_TOOLCHAIN_ONLY}" ]]; then
18121818
cmake_options+=(
18131819
-DSWIFT_TOOL_SIL_OPT_BUILD=FALSE

0 commit comments

Comments
 (0)