Merge pull request swiftlang#35296 from xymus/fix-define-avail-sourcekit

[Sema] Fix storage of availability macros definition for SourceKit

Author: xymus

include/swift/Basic/LangOptions.h

@@ -116,7 +116,7 @@ namespace swift {
     std::string RequireExplicitAvailabilityTarget;
 
     // Availability macros definitions to be expanded at parsing.
-    SmallVector<StringRef, 4> AvailabilityMacros;
+    SmallVector<std::string, 4> AvailabilityMacros;
 
     /// If false, '#file' evaluates to the full path rather than a
     /// human-readable string.

test/SourceKit/Sema/availability_define.swift

@@ -0,0 +1,18 @@
+// RUN: %sourcekitd-test -req=sema %s -- %s \
+// RUN:  -Xfrontend -define-availability \
+// RUN:  -Xfrontend "_iOS8Aligned:macOS 10.10, iOS 8.0" | %FileCheck %s
+
+// REQUIRES: OS=macosx
+
+// Should fail.
+@available(_iOS9Aligned, *)
+public func onMacOS10_11() {}
+// CHECK: key.line: 8
+// CHECK: key.description: "expected 'available' option such as 'unavailable', 'introduced', 'deprecated', 'obsoleted', 'message', or 'renamed'"
+// CHECK: key.line: 8
+// CHECK: key.description: "expected declaration"
+
+// Should be OK.
+@available(_iOS8Aligned, *)
+public func onMacOS10_10() {}
+// CHECK-NOT: key.line