Skip to content

Commit 57b89d5

Browse files
hyphyp
committed
[android] add an android NDK Swift overlay module, and use it instead of Glibc
1 parent 95493f6 commit 57b89d5

File tree

29 files changed

+250
-20
lines changed

29 files changed

+250
-20
lines changed

‎lib/ClangImporter/ClangIncludePaths.cpp

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ createClangArgs(const ASTContext &ctx, clang::driver::Driver &clangDriver) {
180180

181181
static SmallVector<std::pair<std::string, std::string>, 2>
182182
getLibcFileMapping(ASTContext &ctx, StringRef modulemapFileName,
183-
std::optional<StringRef> maybeHeaderFileName,
183+
std::optional<ArrayRef<StringRef>> maybeHeaderFileNames,
184184
const llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> &vfs) {
185185
const llvm::Triple &triple = ctx.LangOpts.Target;
186186

@@ -220,18 +220,20 @@ getLibcFileMapping(ASTContext &ctx, StringRef modulemapFileName,
220220
SmallVector<std::pair<std::string, std::string>, 2> vfsMappings{
221221
{std::string(injectedModuleMapPath), std::string(actualModuleMapPath)}};
222222

223-
if (maybeHeaderFileName) {
224-
// TODO: remove the SwiftGlibc.h header and reference all Glibc headers
225-
// directly from the modulemap.
226-
Path actualHeaderPath = actualModuleMapPath;
227-
llvm::sys::path::remove_filename(actualHeaderPath);
228-
llvm::sys::path::append(actualHeaderPath, maybeHeaderFileName.value());
223+
if (maybeHeaderFileNames) {
224+
for (const auto &filename : *maybeHeaderFileNames) {
225+
// TODO: remove the SwiftGlibc.h header and reference all Glibc headers
226+
// directly from the modulemap.
227+
Path actualHeaderPath = actualModuleMapPath;
228+
llvm::sys::path::remove_filename(actualHeaderPath);
229+
llvm::sys::path::append(actualHeaderPath, filename);
229230

230-
Path injectedHeaderPath(libcDir);
231-
llvm::sys::path::append(injectedHeaderPath, maybeHeaderFileName.value());
231+
Path injectedHeaderPath(libcDir);
232+
llvm::sys::path::append(injectedHeaderPath, filename);
232233

233-
vfsMappings.push_back(
234-
{std::string(injectedHeaderPath), std::string(actualHeaderPath)});
234+
vfsMappings.push_back(
235+
{std::string(injectedHeaderPath), std::string(actualHeaderPath)});
236+
}
235237
}
236238

237239
return vfsMappings;
@@ -552,9 +554,14 @@ ClangInvocationFileMapping swift::getClangInvocationFileMapping(
552554
} else if (triple.isMusl()) {
553555
libcFileMapping =
554556
getLibcFileMapping(ctx, "musl.modulemap", StringRef("SwiftMusl.h"), vfs);
557+
} else if (triple.isAndroid()) {
558+
// Android uses the android-specific module map that overlays the NDK.
559+
StringRef headerFiles[] = {"SwiftAndroidNDK.h", "SwiftBionic.h"};
560+
libcFileMapping =
561+
getLibcFileMapping(ctx, "android.modulemap", headerFiles, vfs);
555562
} else if (triple.isOSGlibc() || triple.isOSOpenBSD() ||
556-
triple.isOSFreeBSD() || triple.isAndroid()) {
557-
// Android/BSD/Linux Mappings
563+
triple.isOSFreeBSD()) {
564+
// BSD/Linux Mappings
558565
libcFileMapping = getLibcFileMapping(ctx, "glibc.modulemap",
559566
StringRef("SwiftGlibc.h"), vfs);
560567

‎stdlib/cmake/modules/AddSwiftStdlib.cmake

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1757,6 +1757,9 @@ endfunction()
17571757
# SWIFT_MODULE_DEPENDS_WASI
17581758
# Swift modules this library depends on when built for WASI.
17591759
#
1760+
# SWIFT_MODULE_DEPENDS_ANDROID
1761+
# Swift modules this library depends on when built for Android.
1762+
#
17601763
# FRAMEWORK_DEPENDS
17611764
# System frameworks this library depends on.
17621765
#
@@ -1880,6 +1883,7 @@ function(add_swift_target_library name)
18801883
SWIFT_COMPILE_FLAGS_XROS
18811884
SWIFT_COMPILE_FLAGS_LINUX
18821885
SWIFT_MODULE_DEPENDS
1886+
SWIFT_MODULE_DEPENDS_ANDROID
18831887
SWIFT_MODULE_DEPENDS_CYGWIN
18841888
SWIFT_MODULE_DEPENDS_FREEBSD
18851889
SWIFT_MODULE_DEPENDS_FREESTANDING
@@ -2091,12 +2095,15 @@ function(add_swift_target_library name)
20912095
elseif(sdk STREQUAL "OPENBSD")
20922096
list(APPEND swiftlib_module_depends_flattened
20932097
${SWIFTLIB_SWIFT_MODULE_DEPENDS_OPENBSD})
2094-
elseif(sdk STREQUAL "LINUX" OR sdk STREQUAL "ANDROID")
2098+
elseif(sdk STREQUAL "LINUX")
20952099
list(APPEND swiftlib_module_depends_flattened
20962100
${SWIFTLIB_SWIFT_MODULE_DEPENDS_LINUX})
20972101
elseif(sdk STREQUAL "LINUX_STATIC")
20982102
list(APPEND swiftlib_module_depends_flattened
20992103
${SWIFTLIB_SWIFT_MODULE_DEPENDS_LINUX_STATIC})
2104+
elseif(sdk STREQUAL "ANDROID")
2105+
list(APPEND swiftlib_module_depends_flattened
2106+
${SWIFTLIB_SWIFT_MODULE_DEPENDS_ANDROID})
21002107
elseif(sdk STREQUAL "CYGWIN")
21012108
list(APPEND swiftlib_module_depends_flattened
21022109
${SWIFTLIB_SWIFT_MODULE_DEPENDS_CYGWIN})
@@ -2920,6 +2927,7 @@ function(add_swift_target_executable name)
29202927
DEPENDS
29212928
LINK_LIBRARIES
29222929
SWIFT_MODULE_DEPENDS
2930+
SWIFT_MODULE_DEPENDS_ANDROID
29232931
SWIFT_MODULE_DEPENDS_CYGWIN
29242932
SWIFT_MODULE_DEPENDS_FREEBSD
29252933
SWIFT_MODULE_DEPENDS_FREESTANDING
@@ -3030,12 +3038,15 @@ function(add_swift_target_executable name)
30303038
elseif(sdk STREQUAL "OPENBSD")
30313039
list(APPEND swiftexe_module_depends_flattened
30323040
${SWIFTEXE_TARGET_SWIFT_MODULE_DEPENDS_OPENBSD})
3033-
elseif(sdk STREQUAL "LINUX" OR sdk STREQUAL "ANDROID")
3041+
elseif(sdk STREQUAL "LINUX")
30343042
list(APPEND swiftexe_module_depends_flattened
30353043
${SWIFTEXE_TARGET_SWIFT_MODULE_DEPENDS_LINUX})
30363044
elseif(sdk STREQUAL "LINUX_STATIC")
30373045
list(APPEND swiftexe_module_depends_flattened
30383046
${SWIFTEXE_TARGET_SWIFT_MODULE_DEPENDS_LINUX_STATIC})
3047+
elseif(sdk STREQUAL "ANDROID")
3048+
list(APPEND swiftexe_module_depends_flattened
3049+
${SWIFTEXE_TARGET_SWIFT_MODULE_DEPENDS_ANDROID})
30393050
elseif(sdk STREQUAL "CYGWIN")
30403051
list(APPEND swiftexe_module_depends_flattened
30413052
${SWIFTEXE_TARGET_SWIFT_MODULE_DEPENDS_CYGWIN})

‎stdlib/private/RuntimeUnittest/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ add_swift_target_library(swiftRuntimeUnittest ${SWIFT_STDLIB_LIBRARY_BUILD_TYPES
88
ExclusivityTests.cpp
99

1010
SWIFT_MODULE_DEPENDS StdlibUnittest
11+
SWIFT_MODULE_DEPENDS_ANDROID Android
1112
SWIFT_MODULE_DEPENDS_LINUX Glibc
1213
SWIFT_MODULE_DEPENDS_FREEBSD Glibc
1314
SWIFT_MODULE_DEPENDS_OPENBSD Glibc

‎stdlib/private/StdlibCollectionUnittest/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ add_swift_target_library(swiftStdlibCollectionUnittest ${SWIFT_STDLIB_LIBRARY_BU
1919
WriteBackMutableSlice.swift
2020

2121
SWIFT_MODULE_DEPENDS StdlibUnittest
22+
SWIFT_MODULE_DEPENDS_ANDROID Android
2223
SWIFT_MODULE_DEPENDS_LINUX Glibc
2324
SWIFT_MODULE_DEPENDS_FREEBSD Glibc
2425
SWIFT_MODULE_DEPENDS_OPENBSD Glibc

‎stdlib/private/StdlibUnicodeUnittest/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ add_swift_target_library(swiftStdlibUnicodeUnittest ${SWIFT_STDLIB_LIBRARY_BUILD
1010
WordBreaking.swift
1111

1212
SWIFT_MODULE_DEPENDS StdlibUnittest
13+
SWIFT_MODULE_DEPENDS_ANDROID Android
1314
SWIFT_MODULE_DEPENDS_LINUX Glibc
1415
SWIFT_MODULE_DEPENDS_FREEBSD Glibc
1516
SWIFT_MODULE_DEPENDS_OPENBSD Glibc

‎stdlib/private/StdlibUnittest/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ add_swift_target_library(swiftStdlibUnittest ${SWIFT_STDLIB_LIBRARY_BUILD_TYPES}
6262
SWIFT_MODULE_DEPENDS_XROS ${swift_stdlib_unittest_darwin_dependencies}
6363
SWIFT_MODULE_DEPENDS_MACCATALYST ${swift_stdlib_unittest_darwin_dependencies}
6464
SWIFT_MODULE_DEPENDS_FREESTANDING "${SWIFT_FREESTANDING_TEST_DEPENDENCIES}"
65+
SWIFT_MODULE_DEPENDS_ANDROID Android
6566
SWIFT_MODULE_DEPENDS_LINUX Glibc
6667
SWIFT_MODULE_DEPENDS_FREEBSD Glibc
6768
SWIFT_MODULE_DEPENDS_OPENBSD Glibc

‎stdlib/private/StdlibUnittest/RaceTest.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ import Darwin
4545
import Glibc
4646
#elseif canImport(Musl)
4747
import Musl
48+
#elseif canImport(Android)
49+
import Android
4850
#elseif os(WASI)
4951
import WASILibc
5052
#elseif os(Windows)

‎stdlib/private/StdlibUnittest/StdlibCoreExtras.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ import Darwin
1818
import Glibc
1919
#elseif canImport(Musl)
2020
import Musl
21+
#elseif canImport(Android)
22+
import Android
2123
#elseif os(WASI)
2224
import WASILibc
2325
#elseif os(Windows)

‎stdlib/private/StdlibUnittest/StdlibUnittest.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ import Darwin
2424
import Glibc
2525
#elseif canImport(Musl)
2626
import Musl
27+
#elseif canImport(Android)
28+
import Android
2729
#elseif os(WASI)
2830
import WASILibc
2931
#elseif os(Windows)

‎stdlib/private/SwiftPrivate/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ add_swift_target_library(swiftSwiftPrivate ${SWIFT_STDLIB_LIBRARY_BUILD_TYPES} I
2727
SWIFT_MODULE_DEPENDS_WATCHOS ${swift_swiftprivate_darwin_depencencies}
2828
SWIFT_MODULE_DEPENDS_MACCATALYST ${swift_swiftprivate_darwin_depencencies}
2929
SWIFT_MODULE_DEPENDS_FREESTANDING "${SWIFT_FREESTANDING_TEST_DEPENDENCIES}"
30+
SWIFT_MODULE_DEPENDS_ANDROID Android
3031
SWIFT_MODULE_DEPENDS_LINUX Glibc
3132
SWIFT_MODULE_DEPENDS_LINUX_STATIC Musl
3233
SWIFT_MODULE_DEPENDS_FREEBSD Glibc

0 commit comments

Comments
 (0)