[NFC] Inline DependencyKey::createForProvidedEntityInterface

Author: CodaFi

include/swift/AST/AbstractSourceFileDepGraphFactory.h

@@ -73,9 +73,11 @@ class AbstractSourceFileDepGraphFactory {
     for (const auto &declOrPair : contentsVec) {
       auto fp =
           AbstractSourceFileDepGraphFactory::getFingerprintIfAny(declOrPair);
-      addADefinedDecl(
-          DependencyKey::createForProvidedEntityInterface<kind>(declOrPair),
-          fp);
+      auto key = DependencyKey::Builder{kind, DeclAspect::interface}
+                    .withContext(declOrPair)
+                    .withName(declOrPair)
+                    .build();
+      addADefinedDecl(key, fp);
     }
   }
 

include/swift/AST/FineGrainedDependencies.h

@@ -535,11 +535,6 @@ class DependencyKey {
   }
   bool isInterface() const { return getAspect() == DeclAspect::interface; }
 
-  /// Create just the interface half of the keys for a provided Decl or Decl
-  /// pair
-  template <NodeKind kind, typename Entity>
-  static DependencyKey createForProvidedEntityInterface(Entity);
-
   DependencyKey correspondingImplementation() const {
     return withAspect(DeclAspect::implementation);
   }

lib/AST/FrontendSourceFileDepGraphFactory.cpp

@@ -65,14 +65,6 @@ static std::string mangleTypeAsContext(const NominalTypeDecl *NTD) {
 // MARK: DependencyKey::Builder
 //==============================================================================
 
-template <NodeKind kindArg, typename Entity>
-DependencyKey DependencyKey::createForProvidedEntityInterface(Entity entity) {
-  return DependencyKey::Builder{kindArg, DeclAspect::interface}
-      .withContext(entity)
-      .withName(entity)
-      .build();
-}
-
 DependencyKey DependencyKey::Builder::build() && {
   return DependencyKey{
     kind,