Merge pull request swiftlang#36197 from slavapestov/reasync-preparations

Refactor TypeCheckEffects.cpp in preparation for 'reasync' checking

Author: slavapestov

include/swift/AST/DiagnosticsSema.def

@@ -4093,7 +4093,7 @@ NOTE(because_rethrows_argument_throws,none,
 NOTE(because_rethrows_default_argument_throws,none,
      "call is to 'rethrows' function, but a defaulted argument function"
      " can throw", ())
-NOTE(because_rethrows_default_conformance_throws,none,
+NOTE(because_rethrows_conformance_throws,none,
      "call is to 'rethrows' function, but a conformance has a throwing witness", ())
 
 ERROR(throwing_call_in_nonthrowing_autoclosure,none,

include/swift/AST/Types.h

@@ -76,6 +76,7 @@ class TypeAliasDecl;
 class TypeDecl;
 class NominalTypeDecl;
 class GenericTypeDecl;
+enum class EffectKind : uint8_t;
 class EnumDecl;
 class EnumElementDecl;
 class SILFunctionType;
@@ -3159,6 +3160,8 @@ class AnyFunctionType : public TypeBase {
 
   bool isThrowing() const { return getExtInfo().isThrowing(); }
 
+  bool hasEffect(EffectKind kind) const;
+
   bool isDifferentiable() const { return getExtInfo().isDifferentiable(); }
   DifferentiabilityKind getDifferentiabilityKind() const {
     return getExtInfo().getDifferentiabilityKind();

lib/AST/Effects.cpp

@@ -20,12 +20,21 @@
 #include "swift/AST/Decl.h"
 #include "swift/AST/ProtocolConformanceRef.h"
 #include "swift/AST/Type.h"
+#include "swift/AST/Types.h"
 #include "swift/AST/TypeCheckRequests.h"
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/Support/raw_ostream.h"
 
 using namespace swift;
 
+bool AnyFunctionType::hasEffect(EffectKind kind) const {
+  switch (kind) {
+  case EffectKind::Throws: return getExtInfo().isThrowing();
+  case EffectKind::Async: return getExtInfo().isAsync();
+  }
+  llvm_unreachable("Bad effect kind");
+}
+
 void swift::simple_display(llvm::raw_ostream &out, const EffectKind kind) {
   switch (kind) {
   case EffectKind::Throws: out << "throws"; return;