Merge pull request swiftlang#35170 from hamishknight/request-denied

[ASTDumper] Don't call isFinal()

Author: CodaFi

lib/AST/ASTDumper.cpp

@@ -772,14 +772,14 @@ namespace {
       }
 
       auto VarD = dyn_cast<VarDecl>(VD);
-      if (VD->isFinal() && !(VarD && VarD->isLet()))
+      const auto &attrs = VD->getAttrs();
+      if (attrs.hasAttribute<FinalAttr>() && !(VarD && VarD->isLet()))
         OS << " final";
-      if (VD->getAttrs().hasAttribute<ObjCAttr>())
+      if (attrs.hasAttribute<ObjCAttr>())
         OS << " @objc";
-      if (VD->getAttrs().hasAttribute<DynamicAttr>())
+      if (attrs.hasAttribute<DynamicAttr>())
         OS << " dynamic";
-      if (auto *attr =
-              VD->getAttrs().getAttribute<DynamicReplacementAttr>()) {
+      if (auto *attr = attrs.getAttribute<DynamicReplacementAttr>()) {
         OS << " @_dynamicReplacement(for: \"";
         OS << attr->getReplacedFunctionName();
         OS << "\")";

test/Frontend/dump-parse-syntactically-valid.swift

@@ -0,0 +1,6 @@
+// RUN: %target-swift-frontend -dump-parse %s
+
+// Make sure we don't do any Sema and don't crash.
+extension X {
+  typealias Y = Z
+}