Merge pull request swiftlang#30254 from DougGregor/cursed-dual-identities

[Clang importer] Suppress method imports found via selector lookup.

Author: DougGregor

lib/ClangImporter/ClangImporter.cpp

@@ -3134,6 +3134,9 @@ void ClangModuleUnit::lookupObjCMethods(
     auto owningClangModule = getClangTopLevelOwningModule(objcMethod, clangCtx);
     if (owningClangModule != clangModule) continue;
 
+    if (shouldSuppressDeclImport(objcMethod))
+      continue;
+
     // If we found a property accessor, import the property.
     if (objcMethod->isPropertyAccessor())
       (void)owner.importDecl(objcMethod->findPropertyDecl(true),

test/ClangImporter/Inputs/frameworks/MismatchedNames.framework/Headers/MismatchedNames-Swift.h

@@ -0,0 +1,16 @@
+#import <objc/NSObject.h>
+
+#  define OBJC_DESIGNATED_INITIALIZER __attribute__((objc_designated_initializer))
+#  define SWIFT_COMPILE_NAME(X) __attribute__((swift_name(X)))
+
+#  define SWIFT_CLASS_NAMED(SWIFT_NAME) __attribute__((objc_subclassing_restricted)) SWIFT_COMPILE_NAME(SWIFT_NAME)
+
+# pragma clang attribute push(__attribute__((external_source_symbol(language="Swift", defined_in="ObjCExportingFramework",generated_declaration))), apply_to=any(function,enum,objc_interface,objc_category,objc_protocol))
+
+SWIFT_CLASS_NAMED("SwiftClass")
+@interface SwiftClass : NSObject
++ (id _Nullable)usingIndex:(id _Nonnull)index;
+- (nonnull instancetype)init OBJC_DESIGNATED_INITIALIZER;
+@end
+
+# pragma clang attribute pop

test/ClangImporter/Inputs/frameworks/MismatchedNames.framework/MismatchedNamesSwift.swift

@@ -0,0 +1,6 @@
+import Foundation
+@_exported import MismatchedNames
+
+@objc public class SwiftClass : NSObject {
+  @objc public class func using(index: AnyObject) -> AnyObject? { return nil }
+}

test/ClangImporter/Inputs/frameworks/MismatchedNames.framework/Modules/module.modulemap

@@ -0,0 +1,6 @@
+framework module MismatchedNames {
+}
+
+module MismatchedNames.Swift {
+  header "MismatchedNames-Swift.h"
+}

test/ClangImporter/objc_mismatched_names.swift

@@ -0,0 +1,22 @@
+// RUN: %empty-directory(%t)
+// RUN: mkdir -p %t/modules
+
+// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -emit-module -module-name MismatchedNames -F %S/Inputs/frameworks -o %t/modules/MismatchedNames.swiftmodule %S/Inputs/frameworks/MismatchedNames.framework/MismatchedNamesSwift.swift
+
+// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -typecheck -F %S/Inputs/frameworks -I %t/modules %s -verify -verify-ignore-unknown
+
+// REQUIRES: objc_interop
+
+
+import Foundation
+import ObjectiveC
+import MismatchedNames
+
+// Ensure that we don't crash when looking up via Objective-C selector and
+// finding a method in the generated header that (due to a missing swift_name
+// attribute) isn't "obviously" matching its corresponding Swift method.
+//
+// rdar://problem/60046206 covers this crash.
+func test() {
+  _ = Selector(("usingIndex:")) // expected-warning{{use '#selector' instead of explicitly constructing a 'Selector'}}
+}