[NFC] Get rid of ASTContext::getModuleByName dups

This method was reimplemented three times in various source tools.

Author: beccadax

tools/SourceKit/lib/SwiftLang/SwiftDocSupport.cpp

@@ -40,16 +40,6 @@ using namespace SourceKit;
 using namespace swift;
 using namespace ide;
 
-static ModuleDecl *getModuleByFullName(ASTContext &Ctx, StringRef ModuleName) {
-  ImportPath::Module::Builder modulePath;
-  while (!ModuleName.empty()) {
-    StringRef SubModuleName;
-    std::tie(SubModuleName, ModuleName) = ModuleName.split('.');
-    modulePath.push_back(Ctx.getIdentifier(SubModuleName));
-  }
-  return Ctx.getModule(modulePath.get());
-}
-
 static ModuleDecl *getModuleByFullName(ASTContext &Ctx, Identifier ModuleName) {
   return Ctx.getModule(ImportPath::Module::Builder(ModuleName).get());
 }
@@ -1026,7 +1016,7 @@ static bool getModuleInterfaceInfo(ASTContext &Ctx, StringRef ModuleName,
   if (!Stdlib)
     return true;
 
-  auto *M = getModuleByFullName(Ctx, ModuleName);
+  auto *M = Ctx.getModuleByName(ModuleName);
   if (!M)
     return true;
 
@@ -1555,7 +1545,7 @@ findModuleGroups(StringRef ModuleName, ArrayRef<const char *> Args,
     Receiver(RequestResult<ArrayRef<StringRef>>::fromError(Error));
     return;
   }
-  auto *M = getModuleByFullName(Ctx, ModuleName);
+  auto *M = Ctx.getModuleByName(ModuleName);
   if (!M) {
     Error = "Cannot find the module.";
     Receiver(RequestResult<ArrayRef<StringRef>>::fromError(Error));

tools/SourceKit/lib/SwiftLang/SwiftEditorInterfaceGen.cpp

@@ -91,16 +91,6 @@ typedef SwiftInterfaceGenContext::Implementation::TextReference TextReference;
 typedef SwiftInterfaceGenContext::Implementation::TextDecl TextDecl;
 typedef SwiftInterfaceGenContext::Implementation::SourceTextInfo SourceTextInfo;
 
-static ModuleDecl *getModuleByFullName(ASTContext &Ctx, StringRef ModuleName) {
-  ImportPath::Module::Builder builder;
-  while (!ModuleName.empty()) {
-    StringRef SubModuleName;
-    std::tie(SubModuleName, ModuleName) = ModuleName.split('.');
-    builder.push_back(Ctx.getIdentifier(SubModuleName));
-  }
-  return Ctx.getModule(builder.get());
-}
-
 static ModuleDecl *getModuleByFullName(ASTContext &Ctx, Identifier ModuleName) {
   return Ctx.getModule(ImportPath::Module::Builder(ModuleName).get());
 }
@@ -293,7 +283,7 @@ static bool getModuleInterfaceInfo(ASTContext &Ctx,
   }
 
   // Get the (sub)module to generate.
-  Mod = getModuleByFullName(Ctx, ModuleName);
+  Mod = Ctx.getModuleByName(ModuleName);
   if (!Mod) {
     ErrMsg = "Could not load module: ";
     ErrMsg += ModuleName;

tools/swift-ide-test/swift-ide-test.cpp

@@ -2111,13 +2111,7 @@ static int doInputCompletenessTest(StringRef SourceFilename) {
 //===----------------------------------------------------------------------===//
 
 static ModuleDecl *getModuleByFullName(ASTContext &Context, StringRef ModuleName) {
-  ImportPath::Module::Builder builder;
-  while (!ModuleName.empty()) {
-    StringRef SubModuleName;
-    std::tie(SubModuleName, ModuleName) = ModuleName.split('.');
-    builder.push_back(Context.getIdentifier(SubModuleName));
-  }
-  ModuleDecl *Result = Context.getModule(builder.get());
+  ModuleDecl *Result = Context.getModuleByName(ModuleName);
   if (!Result || Result->failedToLoad())
     return nullptr;
   return Result;