Skip to content

Commit 61f796d

Browse files
committed
GSB: Remove unused parameter from lookupConformance()
1 parent bc1717b commit 61f796d

File tree

3 files changed

+12
-22
lines changed

3 files changed

+12
-22
lines changed

include/swift/AST/GenericSignatureBuilder.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -537,8 +537,7 @@ class GenericSignatureBuilder {
537537
LookUpConformanceInBuilder getLookupConformanceFn();
538538

539539
/// Lookup a protocol conformance in a module-agnostic manner.
540-
ProtocolConformanceRef lookupConformance(CanType dependentType,
541-
Type conformingReplacementType,
540+
ProtocolConformanceRef lookupConformance(Type conformingReplacementType,
542541
ProtocolDecl *conformedProtocol);
543542

544543
/// Enumerate the requirements that describe the signature of this

lib/AST/GenericSignature.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,8 +440,7 @@ bool GenericSignatureImpl::isRequirementSatisfied(
440440
if (canFirstType->isTypeParameter())
441441
return requiresProtocol(canFirstType, protocol);
442442
else
443-
return (bool)GSB->lookupConformance(/*dependentType=*/CanType(),
444-
canFirstType, protocol);
443+
return (bool)GSB->lookupConformance(canFirstType, protocol);
445444
}
446445

447446
case RequirementKind::SameType: {

lib/AST/GenericSignatureBuilder.cpp

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,8 +1097,7 @@ const RequirementSource *RequirementSource::getMinimalConformanceSource(
10971097
if (parentEquivClass->concreteType)
10981098
derivedViaConcrete = true;
10991099
else if (parentEquivClass->superclass &&
1100-
builder.lookupConformance(parentType->getCanonicalType(),
1101-
parentEquivClass->superclass,
1100+
builder.lookupConformance(parentEquivClass->superclass,
11021101
source->getProtocolDecl()))
11031102
derivedViaConcrete = true;
11041103

@@ -2591,8 +2590,7 @@ GenericSignatureBuilder::resolveConcreteConformance(ResolvedType type,
25912590
concreteSource = equivClass->concreteTypeConstraints.front().source;
25922591

25932592
// Lookup the conformance of the concrete type to this protocol.
2594-
auto conformance =
2595-
lookupConformance(type.getDependentType(), concrete, proto);
2593+
auto conformance = lookupConformance(concrete, proto);
25962594
if (conformance.isInvalid()) {
25972595
if (!concrete->hasError() && concreteSource->getLoc().isValid()) {
25982596
Impl->HadAnyError = true;
@@ -2655,8 +2653,7 @@ const RequirementSource *GenericSignatureBuilder::resolveSuperConformance(
26552653
if (!superclass) return nullptr;
26562654

26572655
// Lookup the conformance of the superclass to this protocol.
2658-
auto conformance =
2659-
lookupConformance(type.getDependentType(), superclass, proto);
2656+
auto conformance = lookupConformance(superclass, proto);
26602657
if (conformance.isInvalid())
26612658
return nullptr;
26622659

@@ -3762,13 +3759,12 @@ GenericSignatureBuilder::LookUpConformanceInBuilder::operator()(
37623759
return conformedProtocol->getModuleContext()->lookupConformance(
37633760
conformingReplacementType, conformedProtocol);
37643761
}
3765-
return builder->lookupConformance(dependentType, conformingReplacementType,
3762+
return builder->lookupConformance(conformingReplacementType,
37663763
conformedProtocol);
37673764
}
37683765

37693766
ProtocolConformanceRef
3770-
GenericSignatureBuilder::lookupConformance(CanType dependentType,
3771-
Type conformingReplacementType,
3767+
GenericSignatureBuilder::lookupConformance(Type conformingReplacementType,
37723768
ProtocolDecl *conformedProtocol) {
37733769
if (conformingReplacementType->isTypeParameter())
37743770
return ProtocolConformanceRef(conformedProtocol);
@@ -3945,13 +3941,11 @@ ResolvedType GenericSignatureBuilder::maybeResolveEquivalenceClass(
39453941
if (baseEquivClass->conformsTo.find(proto)
39463942
== baseEquivClass->conformsTo.end()) {
39473943
if (baseEquivClass->concreteType &&
3948-
lookupConformance(type->getCanonicalType(),
3949-
baseEquivClass->concreteType,
3944+
lookupConformance(baseEquivClass->concreteType,
39503945
proto)) {
39513946
// Fall through
39523947
} else if (baseEquivClass->superclass &&
3953-
lookupConformance(type->getCanonicalType(),
3954-
baseEquivClass->superclass,
3948+
lookupConformance(baseEquivClass->superclass,
39553949
proto)) {
39563950
// Fall through
39573951
} else {
@@ -3985,13 +3979,11 @@ ResolvedType GenericSignatureBuilder::maybeResolveEquivalenceClass(
39853979
: baseEquivClass->superclass);
39863980
} else {
39873981
if (baseEquivClass->concreteType &&
3988-
lookupConformance(type->getCanonicalType(),
3989-
baseEquivClass->concreteType,
3982+
lookupConformance(baseEquivClass->concreteType,
39903983
proto)) {
39913984
parentType = baseEquivClass->concreteType;
39923985
} else if (baseEquivClass->superclass &&
3993-
lookupConformance(type->getCanonicalType(),
3994-
baseEquivClass->superclass,
3986+
lookupConformance(baseEquivClass->superclass,
39953987
proto)) {
39963988
parentType = baseEquivClass->superclass;
39973989
} else {
@@ -5480,7 +5472,7 @@ class GenericSignatureBuilder::InferRequirementsWalker : public TypeWalker {
54805472
auto addSameTypeConstraint = [&](Type firstType,
54815473
AssociatedTypeDecl *assocType) {
54825474
auto *protocol = assocType->getProtocol();
5483-
auto conf = Builder.lookupConformance(CanType(), firstType, protocol);
5475+
auto conf = Builder.lookupConformance(firstType, protocol);
54845476
auto secondType = conf.getAssociatedType(
54855477
firstType, assocType->getDeclaredInterfaceType());
54865478
Requirement req(RequirementKind::SameType, firstType, secondType);

0 commit comments

Comments
 (0)