Merge pull request swiftlang#18963 from CodaFi/its-not-unusual-to-be-unused-by-anyone

[NFC] Silence a bunch of Wunused-variable diagnostics

Author: CodaFi

lib/AST/ASTVerifier.cpp

@@ -1439,8 +1439,7 @@ class Verifier : public ASTWalker {
           assert(knownConcreteErasure != ExistentialErasureOnly);
           knownConcreteErasure = ConcreteErasureOnly;
           concreteTy = concreteMeta->getInstanceType();
-        } else if (auto existentialMeta =
-                     concreteTy->getAs<ExistentialMetatypeType>()) {
+        } else if (concreteTy->is<ExistentialMetatypeType>()) {
           // If this is already forced to be a concrete erasure (say we're going
           // from (P & Q).Type.Protocol to P.Type.Type), then this is invalid,
           // because it would require the existential metatype to be

lib/AST/Decl.cpp

@@ -2054,7 +2054,7 @@ CanType ValueDecl::getOverloadSignatureType() const {
                            isMethod ? 2 : 1)->getCanonicalType();
   }
 
-  if (auto *asd = dyn_cast<AbstractStorageDecl>(this)) {
+  if (isa<AbstractStorageDecl>(this)) {
     // First, get the default overload signature type for the decl. For vars,
     // this is the empty tuple type, as variables cannot be overloaded directly
     // by type. For subscripts, it's their interface type.
@@ -5158,7 +5158,7 @@ AbstractFunctionDecl::getObjCSelector(DeclName preferredName) const {
   } else if (auto func = dyn_cast<FuncDecl>(this)) {
     // Otherwise cast this to be able to access getName()
     baseNameStr = func->getName().str();
-  } else if (auto ctor = dyn_cast<ConstructorDecl>(this)) {
+  } else if (isa<ConstructorDecl>(this)) {
     baseNameStr = "init";
   } else {
     llvm_unreachable("Unknown subclass of AbstractFunctionDecl");

lib/AST/GenericSignatureBuilder.cpp

@@ -3431,7 +3431,7 @@ bool RewriteTreeNode::enumerateRulesRec(
     lhs.push_back(assocType);
 
   SWIFT_DEFER {
-    if (auto assocType = getMatch())
+    if (getMatch())
       lhs.pop_back();
   };
 

lib/AST/TypeJoinMeet.cpp

@@ -172,7 +172,7 @@ CanType TypeJoin::visitStructType(CanType second) {
   assert(First != second);
 
   // Deal with inout cases in visitInOutType.
-  if (auto inoutTy = First->getAs<InOutType>())
+  if (First->is<InOutType>())
     return TypeJoin(second).visit(First);
 
   // FIXME: When possible we should return a protocol or protocol
@@ -233,7 +233,7 @@ CanType TypeJoin::visitBoundGenericStructType(CanType second) {
   assert(First != second);
 
   // Deal with inout cases in visitInOutType.
-  if (auto inoutTy = First->getAs<InOutType>())
+  if (First->is<InOutType>())
     return TypeJoin(second).visit(First);
 
   return Unimplemented;

lib/ClangImporter/SwiftLookupTable.cpp

@@ -448,7 +448,7 @@ void SwiftLookupTable::addEntry(DeclName name, SingleEntry newEntry,
   auto contextOpt = translateContext(effectiveContext);
   if (!contextOpt) {
     // We might be able to resolve this later.
-    if (auto decl = newEntry.dyn_cast<clang::NamedDecl *>()) {
+    if (newEntry.is<clang::NamedDecl *>()) {
       UnresolvedEntries.push_back(
         std::make_tuple(name, newEntry, effectiveContext));
     }

lib/Frontend/CompilerInvocation.cpp

@@ -281,7 +281,7 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args,
     Opts.SolverShrinkUnsolvedThreshold = threshold;
   }
 
-  if (const Arg *A = Args.getLastArg(OPT_solver_disable_shrink))
+  if (Args.getLastArg(OPT_solver_disable_shrink))
     Opts.SolverDisableShrink = true;
 
   if (const Arg *A = Args.getLastArg(OPT_value_recursion_threshold)) {

lib/SIL/Linker.cpp

@@ -157,23 +157,26 @@ void SILLinkerVisitor::linkInVTable(ClassDecl *D) {
 //                                  Visitors
 //===----------------------------------------------------------------------===//
 
+static template<typename Inst>
+bool applyInstCalleeIsGeneric(Inst AI) {
+  return AI->getCallee()->getType().template castTo<SILFunctionType>()
+           ->getGenericSignature();
+}
+
 void SILLinkerVisitor::visitApplyInst(ApplyInst *AI) {
-  if (auto sig = AI->getCallee()->getType().castTo<SILFunctionType>()
-                   ->getGenericSignature()) {
+  if (applyInstCalleeIsGeneric(AI)) {
     visitApplySubstitutions(AI->getSubstitutionMap());
   }
 }
 
 void SILLinkerVisitor::visitTryApplyInst(TryApplyInst *TAI) {
-  if (auto sig = TAI->getCallee()->getType().castTo<SILFunctionType>()
-                   ->getGenericSignature()) {
+  if (applyInstCalleeIsGeneric(TAI)) {
     visitApplySubstitutions(TAI->getSubstitutionMap());
   }
 }
 
 void SILLinkerVisitor::visitPartialApplyInst(PartialApplyInst *PAI) {
-  if (auto sig = PAI->getCallee()->getType().castTo<SILFunctionType>()
-                    ->getGenericSignature()) {
+  if (applyInstCalleeIsGeneric(PAI)) {
     visitApplySubstitutions(PAI->getSubstitutionMap());
   }
 }

lib/SIL/SILProfiler.cpp

@@ -99,7 +99,7 @@ static bool canCreateProfilerForAST(ASTNode N) {
   assert(hasASTBeenTypeChecked(N) && "Cannot use this AST for profiling");
 
   if (auto *D = N.dyn_cast<Decl *>()) {
-    if (auto *AFD = dyn_cast<AbstractFunctionDecl>(D))
+    if (isa<AbstractFunctionDecl>(D))
       return true;
 
     if (isa<TopLevelCodeDecl>(D))

lib/SILGen/SILGenApply.cpp

@@ -4440,7 +4440,7 @@ RValue SILGenFunction::emitApply(ResultPlanPtr &&resultPlan,
 
   // If there's a foreign error parameter, fill it in.
   ManagedValue errorTemp;
-  if (auto foreignError = calleeTypeInfo.foreignError) {
+  if (calleeTypeInfo.foreignError) {
     unsigned errorParamIndex =
         calleeTypeInfo.foreignError->getErrorParameterIndex();
 

lib/SILGen/SILGenBridging.cpp

@@ -947,7 +947,7 @@ SILGenFunction::emitBlockToFunc(SILLocation loc,
 
   CanSILFunctionType substFnTy = thunkTy;
 
-  if (auto genericSig = thunkTy->getGenericSignature()) {
+  if (thunkTy->getGenericSignature()) {
     substFnTy = thunkTy->substGenericArgs(F.getModule(),
                                           interfaceSubs);
   }