[Gardening] Use cast results where possible

Author: CodaFi

lib/SIL/LinearLifetimeChecker.cpp

@@ -219,7 +219,7 @@ void State::initializeConsumingUse(BranchPropagatedUser consumingUser,
     llvm::errs() << "Function: '" << beginBlock->getParent()->getName() << "'\n"
                  << "Found over consume?!\n";
     if (auto v = value) {
-      llvm::errs() << "Value: " << *value;
+      llvm::errs() << "Value: " << *v;
     } else {
       llvm::errs() << "Value: N/A\n";
     }

lib/Sema/CSDiag.cpp

@@ -1297,8 +1297,8 @@ void FailureDiagnosis::diagnoseAmbiguity(Expr *E) {
   // Unresolved/Anonymous ClosureExprs are common enough that we should give
   // them tailored diagnostics.
   if (auto CE = dyn_cast<ClosureExpr>(E->getValueProvidingExpr())) {
-    diagnose(E->getLoc(), diag::cannot_infer_closure_type)
-      .highlight(E->getSourceRange());
+    diagnose(CE->getLoc(), diag::cannot_infer_closure_type)
+      .highlight(CE->getSourceRange());
     return;
   }
 

lib/Sema/TypeCheckAttr.cpp

@@ -2931,7 +2931,7 @@ DynamicallyReplacedDeclRequest::evaluate(Evaluator &evaluator,
 
   // If we can lazily resolve the function, do so now.
   if (auto *LazyResolver = attr->Resolver) {
-    auto decl = attr->Resolver->loadDynamicallyReplacedFunctionDecl(
+    auto decl = LazyResolver->loadDynamicallyReplacedFunctionDecl(
         attr, attr->ResolverContextData);
     attr->Resolver = nullptr;
     return decl;

lib/Sema/TypeCheckDecl.cpp

@@ -578,7 +578,7 @@ IsFinalRequest::evaluate(Evaluator &evaluator, ValueDecl *decl) const {
           VD->getOriginalWrappedProperty(PropertyWrapperSynthesizedPropertyKind::Backing))
         return true;
 
-      if (auto *nominalDecl = VD->getDeclContext()->getSelfClassDecl()) {
+      if (VD->getDeclContext()->getSelfClassDecl()) {
         // If this variable is a class member, mark it final if the
         // class is final, or if it was declared with 'let'.
         auto *PBD = VD->getParentPatternBinding();