Skip to content

Commit 676411f

Browse files
committed
Have dtrace aggregate rr opts and start tracking {retain,release}_n.
Otherwise, one can get results that seem to imply more rr traffic when in reality, one was not tracking {retain,release}_n that as a result of better optimization become just simple retain, release.
1 parent faf3be4 commit 676411f

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

benchmark/scripts/Benchmark_DTrace.in

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ class DTraceResult(perf_test_driver.Result):
3838
@classmethod
3939
def data_headers(cls):
4040
return [
41-
'Name', 'Result', 'strong_retain', 'strong_retain/iter',
42-
'strong_release', 'strong_release/iter']
41+
'Name', 'Result', 'Total RR Opts', 'Total RR Opts/Iter']
4342

4443
@classmethod
4544
def data_format(cls, max_test_len):

benchmark/scripts/perf_test_driver/swift_stats.d

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,22 @@
1212

1313
pid$target:*:swift_retain:entry
1414
{
15-
@counts[probefunc] = count();
15+
@counts["rr-opts"] = count();
1616
}
1717

1818
pid$target:*:swift_release:entry
1919
{
20-
@counts[probefunc] = count();
20+
@counts["rr-opts"] = count();
21+
}
22+
23+
pid$target:*:swift_retain_n:entry
24+
{
25+
@counts["rr-opts"] = count();
26+
}
27+
28+
pid$target:*:swift_release_n:entry
29+
{
30+
@counts["rr-opts"] = count();
2131
}
2232

2333
END

0 commit comments

Comments
 (0)