Skip to content

Commit 683f7f5

Browse files
committed
build: separate out host build of SwiftRemoteMirror
Separate out the host build of SwiftRemoteMirror from the "target" build (the host for the standard library may be different from the host for the compiler). Restructure the build to ensure that we use the correct compiler for building the SwiftRemoteMirror for the host. This fixes a build issue when building for Linux AArch64.
1 parent 5a862e4 commit 683f7f5

File tree

3 files changed

+6
-28
lines changed

3 files changed

+6
-28
lines changed

lib/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ add_subdirectory(Sema)
3838
add_subdirectory(Serialization)
3939
add_subdirectory(SwiftDemangle)
4040
add_subdirectory(SwiftReflection)
41+
add_subdirectory(SwiftRemoteMirror)
4142
add_subdirectory(SIL)
4243
add_subdirectory(SILGen)
4344
add_subdirectory(SILOptimizer)

lib/SwiftRemoteMirror/CMakeLists.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
add_swift_host_library(swiftRemoteMirror STATIC
2+
${SWIFT_SOURCE_DIR}/stdlib/public/SwiftRemoteMirror/SwiftRemoteMirror.cpp)
3+
if(CMAKE_SYSTEM_NAME STREQUAL Windows)
4+
target_compile_definitions(swiftRemoteMirror PRIVATE _LIB)
5+
endif()

stdlib/public/SwiftRemoteMirror/CMakeLists.txt

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -14,31 +14,3 @@ if(SWIFT_BUILD_DYNAMIC_STDLIB)
1414
INSTALL_IN_COMPONENT
1515
swift-remote-mirror)
1616
endif()
17-
18-
# Build a specific version for the host with the host toolchain. This is going
19-
# to be used by tools (e.g. lldb)
20-
if(SWIFT_INCLUDE_TOOLS)
21-
if(NOT SWIFT_BUILD_DYNAMIC_STDLIB)
22-
add_custom_target(swiftRemoteMirror-${SWIFT_SDK_${SWIFT_HOST_VARIANT_SDK}_LIB_SUBDIR})
23-
endif()
24-
25-
if(NOT SWIFT_BUILD_RUNTIME_WITH_HOST_COMPILER)
26-
set(CURRENT_CMAKE_C_COMPILER ${CMAKE_C_COMPILER})
27-
set(CURRENT_CMAKE_CXX_COMPILER ${CMAKE_CXX_COMPILER})
28-
set(CMAKE_C_COMPILER ${HOST_CMAKE_C_COMPILER})
29-
set(CMAKE_CXX_COMPILER ${HOST_CMAKE_CXX_COMPILER})
30-
endif()
31-
32-
add_swift_host_library(swiftRemoteMirror STATIC
33-
SwiftRemoteMirror.cpp)
34-
target_compile_definitions(swiftRemoteMirror PRIVATE _LIB)
35-
target_compile_options(swiftRemoteMirror PRIVATE
36-
${SWIFT_RUNTIME_CXX_FLAGS})
37-
set_property(TARGET swiftRemoteMirror APPEND_STRING PROPERTY LINK_FLAGS
38-
${SWIFT_RUNTIME_LINK_FLAGS})
39-
40-
if(NOT SWIFT_BUILD_RUNTIME_WITH_HOST_COMPILER)
41-
set(CMAKE_C_COMPILER ${CURRENT_CMAKE_C_COMPILER})
42-
set(CMAKE_CXX_COMPILER ${CURRENT_CMAKE_CXX_COMPILER})
43-
endif()
44-
endif()

0 commit comments

Comments
 (0)