Fix use of worklist

zoecarver · zoecarver · commit 6a3d32b6d700 · 2019-12-13T09:33:25.000-08:00
diff --git a/lib/SILOptimizer/IPO/GlobalOpt.cpp b/lib/SILOptimizer/IPO/GlobalOpt.cpp
@@ -1160,8 +1160,8 @@ bool SILGlobalOpt::run() {
   }
 
   // Erase the instructions that we have marked for deletion.
-  while (auto *inst = InstToRemove.pop_back_val()) {
-    inst->eraseFromParent();
+  while (!InstToRemove.isEmpty()) {
+    InstToRemove.pop_back_val()->eraseFromParent();
   }
 
   // After we erase some instructions, re-collect.

Original file line number	Diff line number	Diff line change
`@@ -1160,8 +1160,8 @@ bool SILGlobalOpt::run() {`
`1160`	`1160`	`}`
`1161`	`1161`
`1162`	`1162`	`// Erase the instructions that we have marked for deletion.`
`1163`		`- while (auto *inst = InstToRemove.pop_back_val()) {`
`1164`		`- inst->eraseFromParent();`
	`1163`	`+ while (!InstToRemove.isEmpty()) {`
	`1164`	`+ InstToRemove.pop_back_val()->eraseFromParent();`
`1165`	`1165`	`}`
`1166`	`1166`
`1167`	`1167`	`// After we erase some instructions, re-collect.`