Respond to review comment by @rjmccall.

martinboehme · martinboehme · commit 6a5722058b67 · 2020-04-16T10:52:08.000+02:00
Reinstate fast path where declaration is not a ValueDecl.
diff --git a/lib/IRGen/GenClangDecl.cpp b/lib/IRGen/GenClangDecl.cpp
@@ -41,6 +41,8 @@ void IRGenModule::emitClangDecl(const clang::Decl *decl) {
   if (!valueDecl || valueDecl->isExternallyVisible()) {
     ClangCodeGen->HandleTopLevelDecl(
                           clang::DeclGroupRef(const_cast<clang::Decl*>(decl)));
+    if (!valueDecl)
+      return;
   }
 
   if (!GlobalClangDecls.insert(decl->getCanonicalDecl()).second)

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,8 @@ void IRGenModule::emitClangDecl(const clang::Decl *decl) {`
`41`	`41`	`if (!valueDecl \|\| valueDecl->isExternallyVisible()) {`
`42`	`42`	`ClangCodeGen->HandleTopLevelDecl(`
`43`	`43`	`clang::DeclGroupRef(const_cast<clang::Decl*>(decl)));`
	`44`	`+ if (!valueDecl)`
	`45`	`+ return;`
`44`	`46`	`}`
`45`	`47`
`46`	`48`	`if (!GlobalClangDecls.insert(decl->getCanonicalDecl()).second)`