Skip to content

Commit 6c5a6a3

Browse files
committed
Test: misc. test updates for NoncopyableGenerics
(cherry picked from commit 48beac2)
1 parent 46125c4 commit 6c5a6a3

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

test/ASTGen/types.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,7 @@ func testRepeatEach<each T>(_ t: repeat each T) -> (repeat each T) {
4646
fatalError()
4747
}
4848

49-
// FIXME: this error isn't correct to emit. the parsing might be ignoring the ~
50-
struct FileDescriptor: ~Copyable { // expected-error {{struct 'FileDescriptor' required to be 'Copyable' but is marked with '~Copyable'}}
49+
struct FileDescriptor: ~Copyable {
5150
var fd = 1
5251
}
5352

test/Parse/init_deinit.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ struct FooStructDeinitializerB {
3333
deinit // expected-error {{expected '{' for deinitializer}}
3434
}
3535

36-
struct FooStructDeinitializerC {
36+
struct FooStructDeinitializerC { // expected-note {{consider adding '~Copyable' to struct 'FooStructDeinitializerC'}}
3737
deinit {} // expected-error {{deinitializer cannot be declared in struct 'FooStructDeinitializerC' that conforms to 'Copyable'}}
3838
}
3939

test/decl/protocol/protocols.swift

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
// RUN: %target-typecheck-verify-swift -enable-objc-interop
22

3-
// XFAIL: noncopyable_generics
4-
53
protocol EmptyProtocol { }
64

75
protocol DefinitionsInProtocols {
@@ -104,10 +102,9 @@ struct DoesNotConform : Up {
104102

105103
// Circular protocols
106104

107-
protocol CircleMiddle : CircleStart { func circle_middle() } // expected-error {{protocol 'CircleMiddle' refines itself}}
108-
// expected-note@-1 {{protocol 'CircleMiddle' declared here}}
109-
protocol CircleStart : CircleEnd { func circle_start() } // expected-error {{protocol 'CircleStart' refines itself}}
110-
// expected-note@-1 {{protocol 'CircleStart' declared here}}
105+
protocol CircleMiddle : CircleStart { func circle_middle() }
106+
// expected-note@-1 2 {{protocol 'CircleMiddle' declared here}}
107+
protocol CircleStart : CircleEnd { func circle_start() } // expected-error 2 {{protocol 'CircleStart' refines itself}}
111108
protocol CircleEnd : CircleMiddle { func circle_end()} // expected-note 2 {{protocol 'CircleEnd' declared here}}
112109

113110
protocol CircleEntry : CircleTrivial { }

0 commit comments

Comments
 (0)