Merge pull request swiftlang#24064 from rjmccall/param-attr-checking

[NFC] Late-check parameter attributes

Author: rjmccall

lib/Sema/TypeCheckAttr.cpp

@@ -2471,6 +2471,12 @@ void AttributeChecker::visitCustomAttr(CustomAttr *attr) {
   attr->setInvalid();
 }
 
+void TypeChecker::checkParameterAttributes(ParameterList *params) {
+  for (auto param: *params) {
+    checkDeclAttributes(param);
+  }
+}
+
 void TypeChecker::checkDeclAttributes(Decl *D) {
   AttributeChecker Checker(*this, D);
 

lib/Sema/TypeCheckDecl.cpp

@@ -2419,6 +2419,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
       TC.checkDynamicReplacementAttribute(SD);
     }
 
+    TC.checkParameterAttributes(SD->getIndices());
     TC.checkDefaultArguments(SD->getIndices(), SD);
   }
 
@@ -2931,6 +2932,8 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
     if (FD->getAttrs().hasAttribute<DynamicReplacementAttr>()) {
       TC.checkDynamicReplacementAttribute(FD);
     }
+
+    TC.checkParameterAttributes(FD->getParameters());
   }
 
   void visitModuleDecl(ModuleDecl *) { }
@@ -2945,8 +2948,10 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
     TC.validateDecl(EED);
     TC.checkDeclAttributes(EED);
 
-    if (auto *PL = EED->getParameterList())
+    if (auto *PL = EED->getParameterList()) {
+      TC.checkParameterAttributes(PL);
       TC.checkDefaultArguments(PL, EED);
+    }
 
     checkAccessControl(TC, EED);
   }
@@ -3130,6 +3135,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
     }
 
     TC.checkDeclAttributes(CD);
+    TC.checkParameterAttributes(CD->getParameters());
 
     checkAccessControl(TC, CD);
 

lib/Sema/TypeCheckStmt.cpp

@@ -2061,6 +2061,8 @@ bool TypeChecker::typeCheckDestructorBodyUntil(DestructorDecl *DD,
 }
 
 bool TypeChecker::typeCheckClosureBody(ClosureExpr *closure) {
+  checkParameterAttributes(closure->getParameters());
+
   BraceStmt *body = closure->getBody();
 
   Optional<FunctionBodyTimer> timer;

lib/Sema/TypeChecker.h

@@ -1046,6 +1046,7 @@ class TypeChecker final : public LazyResolver {
   void checkDeclAttributesEarly(Decl *D);
   static void addImplicitDynamicAttribute(Decl *D);
   void checkDeclAttributes(Decl *D);
+  void checkParameterAttributes(ParameterList *params);
   void checkDynamicReplacementAttribute(ValueDecl *D);
   static ValueDecl *findReplacedDynamicFunction(const ValueDecl *d);
   void checkTypeModifyingDeclAttributes(VarDecl *var);