Merge pull request swiftlang#39774 from xedin/fix-no-assert-warnings

[Sema] Fix unused function/variable warnings in no-assertion configuration

Author: xedin

lib/Sema/CSDiagnostics.h

@@ -351,9 +351,11 @@ class MissingConformanceFailure final : public RequirementFailure {
                             std::pair<Type, Type> conformance)
       : RequirementFailure(solution, conformance.first, conformance.second,
                            locator) {
+#ifndef NDEBUG
     auto reqElt = locator->castLastElementTo<LocatorPathElt::AnyRequirement>();
     assert(reqElt.getRequirementKind() == RequirementKind::Conformance ||
            reqElt.getRequirementKind() == RequirementKind::Layout);
+#endif
   }
 
   bool diagnoseAsError() override;
@@ -408,8 +410,10 @@ class SameTypeRequirementFailure final : public RequirementFailure {
   SameTypeRequirementFailure(const Solution &solution, Type lhs, Type rhs,
                              ConstraintLocator *locator)
       : RequirementFailure(solution, lhs, rhs, locator) {
+#ifndef NDEBUG
     auto reqElt = locator->castLastElementTo<LocatorPathElt::AnyRequirement>();
     assert(reqElt.getRequirementKind() == RequirementKind::SameType);
+#endif
   }
 
 protected:
@@ -444,8 +448,10 @@ class SuperclassRequirementFailure final : public RequirementFailure {
   SuperclassRequirementFailure(const Solution &solution, Type lhs, Type rhs,
                                ConstraintLocator *locator)
       : RequirementFailure(solution, lhs, rhs, locator) {
+#ifndef NDEBUG
     auto reqElt = locator->castLastElementTo<LocatorPathElt::AnyRequirement>();
     assert(reqElt.getRequirementKind() == RequirementKind::Superclass);
+#endif
   }
 
 protected:
@@ -869,9 +875,11 @@ class ThrowingFunctionConversionFailure final : public ContextualFailure {
   ThrowingFunctionConversionFailure(const Solution &solution, Type fromType,
                                     Type toType, ConstraintLocator *locator)
       : ContextualFailure(solution, fromType, toType, locator) {
+#ifndef NDEBUG
     auto fnType1 = fromType->castTo<FunctionType>();
     auto fnType2 = toType->castTo<FunctionType>();
     assert(fnType1->isThrowing() != fnType2->isThrowing());
+#endif
   }
 
   bool diagnoseAsError() override;
@@ -890,9 +898,11 @@ class AsyncFunctionConversionFailure final : public ContextualFailure {
   AsyncFunctionConversionFailure(const Solution &solution, Type fromType,
                                  Type toType, ConstraintLocator *locator)
       : ContextualFailure(solution, fromType, toType, locator) {
+#ifndef NDEBUG
     auto fnType1 = fromType->castTo<FunctionType>();
     auto fnType2 = toType->castTo<FunctionType>();
     assert(fnType1->isAsync() != fnType2->isAsync());
+#endif
   }
 
   bool diagnoseAsError() override;

lib/Sema/ConstraintSystem.cpp

@@ -4779,6 +4779,7 @@ ArgumentList *Solution::getArgumentList(ConstraintLocator *locator) const {
   return nullptr;
 }
 
+#ifndef NDEBUG
 /// Given an apply expr, returns true if it is expected to have a direct callee
 /// overload, resolvable using `getChoiceFor`. Otherwise, returns false.
 static bool shouldHaveDirectCalleeOverload(const CallExpr *callExpr) {
@@ -4807,6 +4808,7 @@ static bool shouldHaveDirectCalleeOverload(const CallExpr *callExpr) {
   // Assume that anything else would have a direct callee.
   return true;
 }
+#endif
 
 Type Solution::resolveInterfaceType(Type type) const {
   auto resolvedType = type.transform([&](Type type) -> Type {
@@ -4856,9 +4858,11 @@ Solution::getFunctionArgApplyInfo(ConstraintLocator *locator) const {
   if (!applyArgElt)
     return None;
 
+#ifndef NDEBUG
   auto nextIter = iter + 1;
   assert(!locator->findLast<LocatorPathElt::ApplyArgToParam>(nextIter) &&
          "Multiple ApplyArgToParam components?");
+#endif
 
   // Form a new locator that ends at the apply-arg-to-param element, and
   // simplify it to get the full argument expression.
@@ -5778,9 +5782,11 @@ getRequirementInfo(ConstraintSystem &cs, ConstraintLocator *reqLocator) {
 
   auto path = reqLocator->getPath();
   auto iter = path.rbegin();
+
   auto openedGeneric =
       reqLocator->findLast<LocatorPathElt::OpenedGeneric>(iter);
   assert(openedGeneric);
+  (void)openedGeneric;
 
   auto newPath = path.drop_back(iter - path.rbegin() + 1);
   auto *baseLoc = cs.getConstraintLocator(reqLocator->getAnchor(), newPath);

lib/Sema/TypeCheckConstraints.cpp

@@ -1499,7 +1499,10 @@ CheckedCastKind TypeChecker::typeCheckCheckedCast(Type fromType,
       case BridgingCoercion:
         return CheckedCastKind::BridgingCoercion;
       }
+
       assert(hasCoercion && "Not a coercion?");
+      (void)hasCoercion;
+
       return CheckedCastKind::Coercion;
     }
   }