[Diagnostics] Remove obsolete getResolvedMemberRef

Author: xedin

lib/Sema/CSDiagnostics.cpp

@@ -1277,8 +1277,10 @@ bool RValueTreatedAsLValueFailure::diagnoseAsError() {
             ConstructorDecl::BodyInitKind::Delegating) {
           emitDiagnostic(loc, diag::assignment_let_property_delegating_init,
                       member->getName());
-          if (auto *ref = getResolvedMemberRef(member)) {
-            emitDiagnostic(ref, diag::decl_declared_here, ref->getFullName());
+          if (auto overload = getOverloadChoiceIfAvailable(
+                  getConstraintLocator(member, ConstraintLocator::Member))) {
+            if (auto *ref = overload->choice.getDeclOrNull())
+              emitDiagnostic(ref, diag::decl_declared_here, ref->getFullName());
           }
           return true;
         }

lib/Sema/CSDiagnostics.h

@@ -153,13 +153,6 @@ class FailureDiagnostic {
     return None;
   }
 
-  ValueDecl *getResolvedMemberRef(UnresolvedDotExpr *member) const {
-    auto *locator = getConstraintLocator(member, ConstraintLocator::Member);
-    if (auto overload = getOverloadChoiceIfAvailable(locator))
-      return overload->choice.getDeclOrNull();
-    return nullptr;
-  }
-
   /// Retrieve overload choice resolved for a given locator
   /// by the constraint solver.
   Optional<SelectedOverload>