[Test] Underscored has_pointer_escape.

Use underscores rather than hyphens so that text editors understand the
name as a single word.

Author: nate-chandler

lib/SIL/Utils/OwnershipUtils.cpp

@@ -103,7 +103,7 @@ namespace swift::test {
 // - the value
 // - whether it has a pointer escape
 static FunctionTest OwnershipUtilsHasPointerEscape(
-    "has-pointer-escape", [](auto &function, auto &arguments, auto &test) {
+    "has_pointer_escape", [](auto &function, auto &arguments, auto &test) {
       auto value = arguments.takeValue();
       auto has = findPointerEscape(value);
       value->print(llvm::outs());

test/SILOptimizer/ownership-utils-unit.sil

@@ -38,11 +38,11 @@ right:
   %rinstance = apply %getOwned() : $@convention(thin) () -> (@owned C)
   br exit(%rinstance : $C)
 exit(%instance : @owned $C):
-// CHECK-LABEL: begin running test {{[0-9]+}} of {{[0-9]+}} on test_escape_of_phi_transitive_incoming_value: has-pointer-escape
+// CHECK-LABEL: begin running test {{[0-9]+}} of {{[0-9]+}} on test_escape_of_phi_transitive_incoming_value: has_pointer_escape
 // CHECK:       %14 = argument of bb6 : $C
 // CHECK:       true
-// CHECK-LABEL: end running test {{[0-9]+}} of {{[0-9]+}} on test_escape_of_phi_transitive_incoming_value: has-pointer-escape with
-  specify_test "has-pointer-escape @block.argument"
+// CHECK-LABEL: end running test {{[0-9]+}} of {{[0-9]+}} on test_escape_of_phi_transitive_incoming_value: has_pointer_escape with
+  specify_test "has_pointer_escape @block.argument"
   destroy_value %instance : $C
   %retval = tuple ()
   return %retval : $()
@@ -54,7 +54,7 @@ entry:
   br loop_entry(%instance_1 : $FakeOptional<C>)
 
 loop_entry(%18 : @owned $FakeOptional<C>):
-  specify_test "has-pointer-escape @block.argument"
+  specify_test "has_pointer_escape @block.argument"
   br loop_body
 
 loop_body: