Update CSE test for more precise OSSA optimization

Author: atrick

test/SILOptimizer/cse_ossa_nontrivial.sil

@@ -842,12 +842,15 @@ class TestKlass {
 
 sil [ossa] @use_klass : $@convention(thin) (@guaranteed Klass) -> ()
 
-// Currently ownership rauw does not handle this case
-// CHECK-LABEL: sil [ossa] @cse_ossa_accesspathclonetest :
+// An interior pointer, struct_element_addr, can be reused during an
+// OSSA/RAUW because its new uses are within the borrowed value
+// (function argument %0).
+//
+// CHECK-LABEL: sil [ossa] @cse_ossa_interioruseswithinarg :
 // CHECK: struct_element_addr
-// CHECK: struct_element_addr
-// CHECK-LABEL: } // end sil function 'cse_ossa_accesspathclonetest'
-sil [ossa] @cse_ossa_accesspathclonetest : $@convention(thin) (@guaranteed TestKlass) -> () {
+// CHECK-NOT: struct_element_addr
+// CHECK-LABEL: } // end sil function 'cse_ossa_interioruseswithinarg'
+sil [ossa] @cse_ossa_interioruseswithinarg : $@convention(thin) (@guaranteed TestKlass) -> () {
 bb0(%0 : @guaranteed $TestKlass):
   %1 = ref_element_addr %0 : $TestKlass, #TestKlass.testStruct
   %2 = begin_access [modify] [dynamic] %1 : $*NonTrivialStruct
@@ -865,6 +868,34 @@ bb0(%0 : @guaranteed $TestKlass):
   return %139 : $()
 }
 
+// An interior pointer, struct_element_addr, cannot be reused without
+// cloning the access scope, which we don't do. The two
+// struct_element_addr's are not currently considered equivalent.
+//
+// CHECK-LABEL: sil [ossa] @cse_ossa_outsideaccessscope :
+// CHECK: struct_element_addr
+// CHECK: struct_element_addr
+// CHECK-LABEL: } // end sil function 'cse_ossa_outsideaccessscope'
+sil [ossa] @cse_ossa_outsideaccessscope : $@convention(thin) (@guaranteed TestKlass) -> () {
+bb0(%0 : @guaranteed $TestKlass):
+  %1 = ref_element_addr %0 : $TestKlass, #TestKlass.testStruct
+  %a1 = begin_access [modify] [dynamic] %1 : $*NonTrivialStruct
+  %e1 = struct_element_addr %a1 : $*NonTrivialStruct, #NonTrivialStruct.val
+  %l1 = load_borrow %e1 : $*Klass
+  end_access %a1 : $*NonTrivialStruct
+  %f = function_ref @use_klass : $@convention(thin) (@guaranteed Klass) -> ()
+  %c1 = apply %f(%l1) : $@convention(thin) (@guaranteed Klass) -> ()
+  end_borrow %l1 : $Klass
+  %a2 = begin_access [modify] [dynamic] %1 : $*NonTrivialStruct
+  %e2 = struct_element_addr %a2 : $*NonTrivialStruct, #NonTrivialStruct.val
+  %l2 = load_borrow %e2 : $*Klass
+  end_access %a2 : $*NonTrivialStruct
+  %c2 = apply %f(%l2) : $@convention(thin) (@guaranteed Klass) -> ()
+  end_borrow %l2 : $Klass
+  %139 = tuple ()
+  return %139 : $()
+}
+
 struct X {
   var i: Int64
 }