[ModuleInterface] Remove protected helper, redundant with visible dependencyTracker member.

Author: graydon

include/swift/AST/ModuleLoader.h

@@ -69,11 +69,6 @@ class ModuleLoader {
   DependencyTracker * const dependencyTracker;
   ModuleLoader(DependencyTracker *tracker) : dependencyTracker(tracker) {}
 
-  void addDependency(StringRef file, bool IsSystem=false) {
-    if (dependencyTracker)
-      dependencyTracker->addDependency(file, IsSystem);
-  }
-
 public:
   virtual ~ModuleLoader() = default;
 

include/swift/ClangImporter/ClangImporter.h

@@ -326,8 +326,6 @@ class ClangImporter final : public ClangModuleLoader {
   /// Writes the mangled name of \p clangDecl to \p os.
   void getMangledName(raw_ostream &os, const clang::NamedDecl *clangDecl) const;
 
-  using ClangModuleLoader::addDependency;
-
   // Print statistics from the Clang AST reader.
   void printStatistics() const override;
 

lib/Sema/SourceLoader.cpp

@@ -109,7 +109,9 @@ ModuleDecl *SourceLoader::loadModule(SourceLoc importLoc,
   std::unique_ptr<llvm::MemoryBuffer> inputFile =
     std::move(inputFileOrError.get());
 
-  addDependency(inputFile->getBufferIdentifier());
+  if (dependencyTracker)
+    dependencyTracker->addDependency(inputFile->getBufferIdentifier(),
+                                     /*isSystem=*/false);
 
   // Turn off debugging while parsing other modules.
   llvm::SaveAndRestore<bool> turnOffDebug(Ctx.LangOpts.DebugConstraintSolver,

lib/Serialization/SerializedModuleLoader.cpp

@@ -549,8 +549,9 @@ ModuleDecl *SerializedModuleLoaderBase::loadModule(SourceLoc importLoc,
                     isFramework)) {
       return nullptr;
     }
-
-    addDependency(moduleInputBuffer->getBufferIdentifier());
+    if (dependencyTracker)
+      dependencyTracker->addDependency(moduleInputBuffer->getBufferIdentifier(),
+                                       /*isSystem=*/false);
   }
 
   assert(moduleInputBuffer);