Enclose with begin_access[signed]/end_access during SILGen of implicit value ctor

Author: meg-gupta

lib/IRGen/IRGenSIL.cpp

@@ -5835,7 +5835,8 @@ void IRGenSILFunction::visitBeginAccessInst(BeginAccessInst *access) {
       setLoweredAddress(access, temp.getAddress());
       return;
     }
-    if (access->getAccessKind() == SILAccessKind::Modify) {
+    if (access->getAccessKind() == SILAccessKind::Modify ||
+        access->getAccessKind() == SILAccessKind::Init) {
       // When we see a signed modify access, create a shadow stack location and
       // set the lowered address of the access to this stack location.
       auto temp = ti.allocateStack(*this, access->getType(), "ptrauth.temp");
@@ -5926,7 +5927,8 @@ void IRGenSILFunction::visitEndAccessInst(EndAccessInst *i) {
   }
 
   case SILAccessEnforcement::Signed: {
-    if (access->getAccessKind() != SILAccessKind::Modify) {
+    if (access->getAccessKind() != SILAccessKind::Modify ||
+        access->getAccessKind() != SILAccessKind::Init) {
       // nothing to do.
       return;
     }

lib/SILGen/SILGenConstructor.cpp

@@ -207,6 +207,13 @@ static void emitImplicitValueConstructor(SILGenFunction &SGF,
       SILValue slot =
         SGF.B.createStructElementAddr(Loc, resultSlot, field,
                                       fieldTy.getAddressType());
+
+      if (SGF.getOptions().EnableImportPtrauthFieldFunctionPointers &&
+          field->getPointerAuthQualifier().isPresent()) {
+        slot = SGF.B.createBeginAccess(
+            Loc, slot, SILAccessKind::Init, SILAccessEnforcement::Signed,
+            /* noNestedConflict */ false, /* fromBuiltin */ false);
+      }
       InitializationPtr init(new KnownAddressInitialization(slot));
 
       // If it's memberwise initialized, do so now.
@@ -260,6 +267,10 @@ static void emitImplicitValueConstructor(SILGenFunction &SGF,
 
         SGF.emitExprInto(field->getParentInitializer(), init.get());
       }
+      if (SGF.getOptions().EnableImportPtrauthFieldFunctionPointers &&
+          field->getPointerAuthQualifier().isPresent()) {
+        SGF.B.createEndAccess(Loc, slot, /* aborted */ false);
+      }
     }
 
     SGF.B.createReturn(ImplicitReturnLocation(Loc),