[Constraint solver] Drop unused Expr* from diagnoseAmbiguity().

We've made this unnecessary.

Author: DougGregor

lib/Sema/ConstraintSystem.cpp

@@ -2503,7 +2503,7 @@ bool ConstraintSystem::salvage(SmallVectorImpl<Solution> &viable, Expr *expr) {
         }
       }
 
-      if (diagnoseAmbiguity(expr, viable)) {
+      if (diagnoseAmbiguity(viable)) {
         return true;
       }
     }
@@ -2757,8 +2757,7 @@ static void extendPreorderIndexMap(
   expr->walk(traversal);
 }
 
-bool ConstraintSystem::diagnoseAmbiguity(Expr *expr,
-                                         ArrayRef<Solution> solutions) {
+bool ConstraintSystem::diagnoseAmbiguity(ArrayRef<Solution> solutions) {
   // Produce a diff of the solutions.
   SolutionDiff diff(solutions);
 

lib/Sema/ConstraintSystem.h

@@ -2104,7 +2104,7 @@ class ConstraintSystem {
   /// emits an error message.
   void diagnoseFailureForExpr(Expr *expr);
 
-  bool diagnoseAmbiguity(Expr *expr, ArrayRef<Solution> solutions);
+  bool diagnoseAmbiguity(ArrayRef<Solution> solutions);
   bool diagnoseAmbiguityWithFixes(ArrayRef<Solution> solutions);
 
   /// Give the deprecation warning for referring to a global function