Skip to content

Commit 7933a9c

Browse files
authored
Merge pull request swiftlang#25450 from apple/remove-obsolete-tsan-flag
[TSan] Remove usage of obsolete flag in tests
2 parents b1b0c69 + 3ef69d2 commit 7933a9c

File tree

6 files changed

+8
-11
lines changed

6 files changed

+8
-11
lines changed

test/Sanitizers/tsan-norace-block-release.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// RUN: %target-swiftc_driver %s -g -sanitize=thread %import-libdispatch -target %sanitizers-target-triple -o %t_tsan-binary
22
// RUN: %target-codesign %t_tsan-binary
3-
// RUN: env %env-TSAN_OPTIONS=abort_on_error=0:ignore_interceptors_accesses=1 %target-run %t_tsan-binary 2>&1 | %FileCheck %s --implicit-check-not='ThreadSanitizer'
3+
// RUN: env %env-TSAN_OPTIONS=abort_on_error=0 %target-run %t_tsan-binary 2>&1 | %FileCheck %s --implicit-check-not='ThreadSanitizer'
44
// REQUIRES: executable_test
55
// REQUIRES: tsan_runtime
66

test/Sanitizers/tsan-norace-deinit-run-time.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// RUN: %target-swiftc_driver %s -g -sanitize=thread %import-libdispatch -target %sanitizers-target-triple -o %t_tsan-binary
22
// RUN: %target-codesign %t_tsan-binary
3-
// RUN: env %env-TSAN_OPTIONS=abort_on_error=0:ignore_interceptors_accesses=1 %target-run %t_tsan-binary 2>&1 | %FileCheck %s --implicit-check-not='ThreadSanitizer'
3+
// RUN: env %env-TSAN_OPTIONS=abort_on_error=0 %target-run %t_tsan-binary 2>&1 | %FileCheck %s --implicit-check-not='ThreadSanitizer'
44
// REQUIRES: executable_test
55
// REQUIRES: tsan_runtime
66

validation-test/Sanitizers/tsan-ignores-arc-locks.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: %target-build-swift -target %sanitizers-target-triple -sanitize=thread %s -o %t_binary
2-
// RUN: %env-TSAN_OPTIONS=ignore_interceptors_accesses=1:halt_on_error=1 %target-run %t_binary
2+
// RUN: %env-TSAN_OPTIONS=halt_on_error=1 %target-run %t_binary
33
// REQUIRES: executable_test
44
// REQUIRES: stress_test
55
// REQUIRES: tsan_runtime

validation-test/Sanitizers/tsan-inout.swift

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
// RUN: %target-build-swift %S/Inputs/tsan-uninstrumented.swift -target %sanitizers-target-triple -c -module-name TSanUninstrumented -parse-as-library -o %t/TSanUninstrumented.o
55
// RUN: %target-swiftc_driver %s %t/TSanUninstrumented.o -target %sanitizers-target-triple -I%t -L%t -g -sanitize=thread %import-libdispatch -o %t/tsan-binary
66
// RUN: not env %env-TSAN_OPTIONS=abort_on_error=0 %target-run %t/tsan-binary 2>&1 | %FileCheck %s
7-
// RUN: not env %env-TSAN_OPTIONS=abort_on_error=0:ignore_interceptors_accesses=0 %target-run %t/tsan-binary 2>&1 | %FileCheck %s --check-prefix CHECK-INTERCEPTORS-ACCESSES
87
// REQUIRES: executable_test
98
// REQUIRES: stress_test
109
// REQUIRES: tsan_runtime
@@ -170,14 +169,12 @@ testRace(name: "InoutAccessToStoredGlobalInUninstrumentedModule",
170169
// CHECK: Location is global
171170

172171
// These access a global declared in the TSanUninstrumented module.
173-
// This test requires ignore_interceptors_accesses=0 because
174-
// the read from the global is IRGen'd to a memcpy().
175172
testRace(name: "ReadAndWriteToStoredGlobalInUninstrumentedModule",
176173
thread: { storedGlobalInUninstrumentedModule2 = 7 },
177174
thread: { uninstrumentedBlackHole(storedGlobalInUninstrumentedModule2) } )
178-
// CHECK-INTERCEPTORS-ACCESSES-LABEL: Running ReadAndWriteToStoredGlobalInUninstrumentedModule
179-
// CHECK-INTERCEPTORS-ACCESSES: ThreadSanitizer: data race
180-
// CHECK-INTERCEPTORS-ACCESSES: Location is global
175+
// CHECK-LABEL: Running ReadAndWriteToStoredGlobalInUninstrumentedModule
176+
// CHECK: ThreadSanitizer: data race
177+
// CHECK: Location is global
181178

182179
// These access a computed global declared in the TSanUninstrumented module
183180
testRace(name: "InoutAccessToComputedGlobalInUninstrumentedModule",

validation-test/Sanitizers/tsan-type-metadata.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: %target-swiftc_driver -target %sanitizers-target-triple -sanitize=thread %import-libdispatch %s -o %t_binary
2-
// RUN: %env-TSAN_OPTIONS=ignore_interceptors_accesses=1:halt_on_error=1 %target-run %t_binary
2+
// RUN: %env-TSAN_OPTIONS=halt_on_error=1 %target-run %t_binary
33
// REQUIRES: executable_test
44
// REQUIRES: stress_test
55
// REQUIRES: tsan_runtime

validation-test/Sanitizers/witness_table_lookup.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: %target-build-swift -sanitize=thread %import-libdispatch -target %sanitizers-target-triple %s -o %t_binary
2-
// RUN: %env-TSAN_OPTIONS=ignore_interceptors_accesses=1:halt_on_error=1 %target-run %t_binary
2+
// RUN: %env-TSAN_OPTIONS=halt_on_error=1 %target-run %t_binary
33
// REQUIRES: executable_test
44
// REQUIRES: stress_test
55
// REQUIRES: tsan_runtime

0 commit comments

Comments
 (0)