Only import constructors marked noexcept.

Author: martinboehme

lib/ClangImporter/ImportDecl.cpp

@@ -3893,7 +3893,12 @@ namespace {
 
       AbstractFunctionDecl *result = nullptr;
       if (auto *ctordecl = dyn_cast<clang::CXXConstructorDecl>(decl)) {
-        // TODO: Is failable, throws etc. correct?
+        // For the time being, we only import `noexcept` constructors.
+        // TODO: Import throwing constructors too.
+        auto *prototype = decl->getType()->getAs<clang::FunctionProtoType>();
+        if (!prototype || !prototype->hasNoexceptExceptionSpec())
+          return nullptr;
+
         DeclName ctorName(Impl.SwiftContext, DeclBaseName::createConstructor(),
                           bodyParams);
         result = Impl.createDeclWithClangNode<ConstructorDecl>(

test/CXXInterop/Inputs/cxx_constructors.h

@@ -1,5 +1,5 @@
 struct ExplicitDefaultConstructor {
-  ExplicitDefaultConstructor() : x(42) {}
+  ExplicitDefaultConstructor() noexcept : x(42) {}
   int x;
 };
 
@@ -17,6 +17,10 @@ struct DefaultConstructorDeleted {
 };
 
 struct ConstructorWithParam {
-  ConstructorWithParam(int val) : x(val) {}
+  ConstructorWithParam(int val) noexcept : x(val) {}
   int x;
 };
+
+struct PotentiallyThrowingConstructor {
+  PotentiallyThrowingConstructor() {}
+};

test/CXXInterop/cxx-constructors-typecheck.swift

@@ -11,3 +11,6 @@ let deletedImplicitly = ConstructorWithParam() // expected-error {{missing argum
 let deletedExplicitly = DefaultConstructorDeleted() // expected-error {{cannot be constructed because it has no accessible initializers}}
 
 let withArg = ConstructorWithParam(42)
+
+// For the time being, we only import constructors marked `noexcept`.
+let potentiallyThrowing = PotentiallyThrowingConstructor() // expected-error {{cannot be constructed because it has no accessible initializers}}