Skip to content

Commit 7ae331d

Browse files
committed
[NFC] Pick a few nits for Jordan
1 parent c37fee1 commit 7ae331d

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

lib/Sema/TypeCheckDeclObjC.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,7 @@ bool swift::isRepresentableInObjC(const SubscriptDecl *SD, ObjCReason Reason) {
827827
if (checkObjCInForeignClassContext(SD, Reason))
828828
return false;
829829

830-
// Obj-C doesn't support class subscripts.
830+
// ObjC doesn't support class subscripts.
831831
if (!SD->isInstanceMember()) {
832832
if (Diagnose) {
833833
SD->diagnose(diag::objc_invalid_on_static_subscript,

test/Constraints/subscript.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ protocol IntToStringSubscript {
1111
subscript (i : Int) -> String { get }
1212
}
1313

14-
class LameDictionary {
14+
class FauxDictionary {
1515
subscript (i : Int) -> String {
1616
get {
1717
return String(i)
1818
}
1919
}
2020
}
2121

22-
func archetypeSubscript<T : IntToStringSubscript, U : LameDictionary>(_ t: T, u: U)
22+
func archetypeSubscript<T : IntToStringSubscript, U : FauxDictionary>(_ t: T, u: U)
2323
-> String {
2424
// Subscript an archetype.
2525
if false { return t[17] }
@@ -40,7 +40,7 @@ protocol IntToStringStaticSubscript {
4040
static subscript (i : Int) -> String { get }
4141
}
4242

43-
class LameStaticDictionary {
43+
class FauxStaticDictionary {
4444
static subscript (i : Int) -> String {
4545
get {
4646
return String(i)
@@ -49,7 +49,7 @@ class LameStaticDictionary {
4949
}
5050

5151
func archetypeStaticSubscript<
52-
T : IntToStringStaticSubscript, U : LameStaticDictionary
52+
T : IntToStringStaticSubscript, U : FauxStaticDictionary
5353
>(_ t: T.Type, u: U.Type) -> String {
5454
// Subscript an archetype.
5555
if false { return t[17] }

test/Interpreter/SDK/dictionary_pattern_matching.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ struct State {
1111
let abbrev: String
1212
}
1313

14-
func stateFromPlistLame(_ plist: Dictionary<String, Any>) -> State? {
14+
func stateFromPlistVerbose(_ plist: Dictionary<String, Any>) -> State? {
1515
if let name = plist["name"] as? NSString {
1616
if let population = plist["population"] as? NSNumber {
1717
if let abbrev = plist["abbrev"] as? NSString {
@@ -62,22 +62,22 @@ let invalidStatePlist3: Dictionary<String, Any> = [
6262
// CHECK: name: "California"
6363
// CHECK: population: 38040000
6464
// CHECK: abbrev: "CA"
65-
dump(stateFromPlistLame(goodStatePlist))
65+
dump(stateFromPlistVerbose(goodStatePlist))
6666
// CHECK-LABEL: some:
6767
// CHECK: name: "California"
6868
// CHECK: population: 38040000
6969
// CHECK: abbrev: "CA"
7070
dump(stateFromPlistCool(goodStatePlist))
7171
// CHECK-LABEL: nil
72-
dump(stateFromPlistLame(invalidStatePlist1))
72+
dump(stateFromPlistVerbose(invalidStatePlist1))
7373
// CHECK-LABEL: nil
7474
dump(stateFromPlistCool(invalidStatePlist1))
7575
// CHECK-LABEL: nil
76-
dump(stateFromPlistLame(invalidStatePlist2))
76+
dump(stateFromPlistVerbose(invalidStatePlist2))
7777
// CHECK-LABEL: nil
7878
dump(stateFromPlistCool(invalidStatePlist2))
7979
// CHECK-LABEL: nil
80-
dump(stateFromPlistLame(invalidStatePlist3))
80+
dump(stateFromPlistVerbose(invalidStatePlist3))
8181
// CHECK-LABEL: nil
8282
dump(stateFromPlistCool(invalidStatePlist3))
8383

test/Interpreter/generic_subscript_static.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
//
33
// This source file is part of the Swift.org open source project
44
//
5-
// Copyright (c) 2014 - 2017 Apple Inc. and the Swift project authors
5+
// Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors
66
// Licensed under Apache License v2.0 with Runtime Library Exception
77
//
88
// See https://swift.org/LICENSE.txt for license information

0 commit comments

Comments
 (0)