[test] Adding SR-12745 test cases

Author: LucianoPAlmeida

include/swift/AST/DiagnosticsSema.def

@@ -57,11 +57,6 @@ ERROR(could_not_find_value_subscript,none,
       "value of type %0 has no subscripts",
       (Type))
 
-ERROR(could_not_find_value_subscript_key_path,none,
-      "value of type %0 has no matching subscript candidates; "
-      "did you mean to use a key path subscript?",
-      (Type))
-
 ERROR(could_not_find_tuple_member,none,
       "value of tuple type %0 has no member %1", (Type, DeclNameRef))
 
@@ -78,8 +73,8 @@ ERROR(could_not_find_value_dynamic_member,none,
       (Type, Type, DeclNameRef))
 ERROR(cannot_infer_contextual_keypath_type_specify_root,none,
       "cannot infer key path type from context; consider explicitly adding a root type", ())
-ERROR(cannot_infer_contextual_keypath_type_any_contextual,none,
-     "'AnyKeyPath' does not provide enough context for root type to be inferred implicitly; "
+ERROR(cannot_infer_keypath_root_anykeypath_context,none,
+     "'AnyKeyPath' does not provide enough context for root type to be inferred; "
      "consider explicitly adding a root type", ())
 
 ERROR(could_not_find_type_member,none,

lib/Sema/CSDiagnostics.cpp

@@ -6282,7 +6282,7 @@ bool UnableToInferKeyPathRootFailure::diagnoseAsError() {
     if (contextualType &&
         contextualType->getAnyNominal() == ctx.getAnyKeyPathDecl()) {
       return emitDiagnostic(
-          diag::cannot_infer_contextual_keypath_type_any_contextual);
+          diag::cannot_infer_keypath_root_anykeypath_context);
     }
     return emitDiagnostic(
         diag::cannot_infer_contextual_keypath_type_specify_root);

lib/Sema/CSFix.h

@@ -261,7 +261,7 @@ enum class FixKind : uint8_t {
   /// Allow key path to be bound to a function type with more than 1 argument
   AllowMultiArgFuncKeyPathMismatch,
 
-  /// Specify key path root type when it cannot be infered by context.
+  /// Specify key path root type when it cannot be infered from context.
   SpecifyKeyPathRootType,
 
 };

test/expr/unary/keypath/keypath.swift

@@ -195,9 +195,9 @@ func testKeyPath(sub: Sub, optSub: OptSub,
 
   let _: AnyKeyPath = \A.property
   let _: AnyKeyPath = \C<A>.value
-  let _: AnyKeyPath = \.property // expected-error{{ambiguous}}
+  let _: AnyKeyPath = \.property // expected-error {{'AnyKeyPath' does not provide enough context for root type to be inferred; consider explicitly adding a root type}} {{24-24=<#Root#>}}
   let _: AnyKeyPath = \C.value // expected-error{{generic parameter 'T' could not be inferred}}
-  let _: AnyKeyPath = \.value // expected-error{{ambiguous}}
+  let _: AnyKeyPath = \.value // expected-error {{'AnyKeyPath' does not provide enough context for root type to be inferred; consider explicitly adding a root type}} {{24-24=<#Root#>}}
 
   let _ = \Prop.[nonHashableSub] // expected-error{{subscript index of type 'NonHashableSub' in a key path must be Hashable}}
   let _ = \Prop.[sub, sub]
@@ -893,6 +893,15 @@ struct SR_12290 {
   }
 }
 
+func testKeyPathHole() {
+  _ = \.x // expected-error {{cannot infer key path type from context; consider explicitly adding a root type}} {{8-8=<#Root#>}}
+  let _ : AnyKeyPath = \.x 
+  // expected-error@-1 {{'AnyKeyPath' does not provide enough context for root type to be inferred; consider explicitly adding a root type}} {{25-25=<#Root#>}}
+
+  func f(_ i: Int) {}
+  f(\.x) // expected-error {{cannot infer key path type from context; consider explicitly adding a root type}} {{6-6=<#Root#>}}
+}
+
 func testSyntaxErrors() { // expected-note{{}}
   _ = \.  ; // expected-error{{expected member name following '.'}}
   _ = \.a ;