Skip to content

Commit 7ca3876

Browse files
author
Harlan Haskins
committed
[TBDGen] Add the unmangled name to the IR-not-TBD diff list
In c94b952 I accidentally started adding StringRefs to an outer-scope vector from a local SmallString instead of the ones that lived in the IR module I was reading from. Instead, put the original symbol name from the IR instead of the "mangled" (leading _ variant) into the diff list.
1 parent 3971c0a commit 7ca3876

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

lib/FrontendTool/TBD.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,9 @@ static bool validateSymbolSet(DiagnosticEngine &diags,
102102
if (!GV->isDeclaration() && externallyVisible) {
103103
// Is it listed?
104104
if (!symbols.erase(name))
105-
irNotTBD.push_back(name);
105+
// Note: Add the unmangled name to the irNotTBD list, which is owned
106+
// by the IRModule, instead of the mangled name.
107+
irNotTBD.push_back(unmangledName);
106108
}
107109
} else {
108110
assert(symbols.find(name) == symbols.end() &&

0 commit comments

Comments
 (0)