Sema: Correctly thread PreparedOverloadBuilder through InferableTypeOpener

Author: slavapestov

lib/Sema/ConstraintSystem.cpp

@@ -3508,8 +3508,10 @@ void OpenGenericTypeRequirements::operator()(GenericTypeDecl *decl,
   cs.recordOpenedTypes(locator, replacements, preparedOverload,
                        /*fixmeAllowDuplicates*/ true);
 
-  for (auto [gp, typeVar] : replacements)
-    cs.addConstraint(ConstraintKind::Bind, typeVar, subst(gp), locator);
+  for (auto [gp, typeVar] : replacements) {
+    cs.addConstraint(ConstraintKind::Bind, typeVar, subst(gp), locator,
+                     /*isFavored=*/false, preparedOverload);
+  }
 
   auto openType = [&](Type ty) -> Type {
     return cs.openType(ty, replacements, locator, preparedOverload);

lib/Sema/TypeOfReference.cpp

@@ -303,7 +303,8 @@ class InferableTypeOpener final {
     // an invalid AST node.
     if (type->hasError()) {
       cs.recordFix(
-          IgnoreInvalidASTNode::create(cs, cs.getConstraintLocator(locator)));
+          IgnoreInvalidASTNode::create(cs, cs.getConstraintLocator(locator)),
+          /*impact=*/1, preparedOverload);
     }
     return type.transformRec([&](Type type) -> std::optional<Type> {
       if (!type->hasUnboundGenericType() && !type->hasPlaceholder() &&