MandatoryPerformanceOptimizations: trigger another iteration if dead allocations were removed

eeckstein · eeckstein · commit 80051feb4c9e · 2024-01-31T17:16:18.000+01:00
diff --git a/SwiftCompilerSources/Sources/Optimizer/ModulePasses/MandatoryPerformanceOptimizations.swift b/SwiftCompilerSources/Sources/Optimizer/ModulePasses/MandatoryPerformanceOptimizations.swift
@@ -111,7 +111,7 @@ private func optimize(function: Function, _ context: FunctionPassContext, _ work
 
     // If this is a just specialized function, try to optimize copy_addr, etc.
     changed = context.optimizeMemoryAccesses(in: function) || changed
-    _ = context.eliminateDeadAllocations(in: function)
+    changed = context.eliminateDeadAllocations(in: function) || changed
   }
 
   worklist.add(calleesOf: function)

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ private func optimize(function: Function, _ context: FunctionPassContext, _ work`
`111`	`111`
`112`	`112`	`// If this is a just specialized function, try to optimize copy_addr, etc.`
`113`	`113`	`changed = context.optimizeMemoryAccesses(in: function) \|\| changed`
`114`		`- _ = context.eliminateDeadAllocations(in: function)`
	`114`	`+ changed = context.eliminateDeadAllocations(in: function) \|\| changed`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`worklist.add(calleesOf: function)`