Remove debug code and update check for successful conversion of

arguments.

Author: zoecarver

lib/IRGen/AllocStackHoisting.cpp

@@ -421,8 +421,6 @@ void HoistAllocStack::hoist() {
 /// Try to hoist generic alloc_stack instructions to the entry block.
 /// Returns true if the function was changed.
 bool HoistAllocStack::run() {
-  llvm::errs() << "Running hoist alloc stack on: " << F->getName() << "\n";
-  
   collectHoistableInstructions();
 
   // Nothing to hoist?
@@ -443,7 +441,6 @@ class AllocStackHoisting : public SILFunctionTransform {
     if (Changed) {
       PM->invalidateAnalysis(F, SILAnalysis::InvalidationKind::Instructions);
     }
-    llvm::errs() << "Completed alloc stack hoisting pass.\n";
   }
 };
 } // end anonymous namespace

lib/SILOptimizer/PassManager/PassManager.cpp

@@ -407,11 +407,6 @@ void SILPassManager::runPassOnFunction(unsigned TransIdx, SILFunction *F) {
   Mod->registerDeleteNotificationHandler(SFT);
   if (breakBeforeRunning(F->getName(), SFT))
     LLVM_BUILTIN_DEBUGTRAP;
-  llvm::errs() << "Running SIL pass: " << SFT->getID() << "\n";
-  llvm::errs() << "Function named: " << F->getName() << "\n";
-  F->getLocation().dump(F->getModule().getSourceManager());
-  llvm::errs() << "***** \n";
-  
   SFT->run();
   assert(analysesUnlocked() && "Expected all analyses to be unlocked!");
   Mod->removeDeleteNotificationHandler(SFT);

lib/SILOptimizer/SILCombiner/SILCombinerApplyVisitors.cpp

@@ -907,8 +907,6 @@ SILInstruction *SILCombiner::createApplyWithConcreteType(
       if (argSub) {
         concreteArgCopies.push_back(*argSub);
         NewArgs.push_back(argSub->tempArg);
-      } else {
-        NewArgs.clear();
       }
     } else {
       // Otherwise, we can just use the value itself.
@@ -936,7 +934,7 @@ SILInstruction *SILCombiner::createApplyWithConcreteType(
         });
   }
 
-  if (NewArgs.empty()) {
+  if (NewArgs.size() != Apply.getNumArguments()) {
     // Remove any new instructions created while attempting to optimize this
     // apply. Since the apply was never rewritten, if they aren't removed here,
     // they will be removed later as dead when visited by SILCombine, causing

lib/Sema/TypeChecker.cpp

@@ -559,14 +559,12 @@ swift::handleSILGenericParams(GenericParamList *genericParams,
     auto genericParams = nestedList[i];
     genericParams->setDepth(i);
   }
-  llvm::errs() << "Checking generic sig...";
+
   auto sig =
       TypeChecker::checkGenericSignature(nestedList.back(), DC,
                                          /*parentSig=*/nullptr,
                                          /*allowConcreteGenericParams=*/true);
-  auto out = (sig ? sig->getGenericEnvironment() : nullptr);
-  llvm::errs() << "done.\n";
-  return out;
+  return (sig ? sig->getGenericEnvironment() : nullptr);
 }
 
 void swift::typeCheckPatternBinding(PatternBindingDecl *PBD,