File tree Expand file tree Collapse file tree 2 files changed +22
-8
lines changed Expand file tree Collapse file tree 2 files changed +22
-8
lines changed Original file line number Diff line number Diff line change 8
8
- [ @swift-ci ] ( #swift-ci )
9
9
- [ Smoke Testing] ( #smoke-testing )
10
10
- [ Validation Testing] ( #validation-testing )
11
- - [ Lint Testing ] ( #lint-testing )
11
+ - [ Linting ] ( #linting )
12
12
- [ Specific Preset Testing] ( #specific-preset-testing )
13
13
- [ Cross Repository Testing] ( #cross-repository-testing )
14
14
- [ ci.swift.org bots] ( #ciswiftorg-bots )
@@ -28,7 +28,7 @@ Users with [commit access](https://swift.org/contributing/#commit-access) can tr
28
28
1 . Smoke Testing
29
29
2 . Validation Testing
30
30
3 . Benchmarking.
31
- 4 . Lint Testing
31
+ 4 . Linting
32
32
5 . Source Compatibility Testing
33
33
6 . Specific Preset Testing
34
34
@@ -121,11 +121,11 @@ Platform | Comment | Check Status
121
121
macOS platform | @swift-ci Please benchmark | Swift Benchmark on OS X Platform (many runs - rigorous)
122
122
macOS platform | @swift-ci Please smoke benchmark | Swift Benchmark on OS X Platform (few runs - sanity)
123
123
124
- ### Lint Testing
124
+ ### Linting
125
125
126
- Language | Comment | Check Status
127
- ------------ | ------- | ------------
128
- Python | @swift-ci Please Python lint | Python lint
126
+ Language | Comment | What it Does | Corresponding Local Command
127
+ ------------ | ------- | ------------ | -------------
128
+ Python | @swift-ci Please Python lint | Lints Python sources | ` ./utils/python_lint.py `
129
129
130
130
### Source Compatibility Testing
131
131
Original file line number Diff line number Diff line change @@ -23,8 +23,22 @@ def lint(arguments, verbose=True):
23
23
)
24
24
if flake8_result != 0 :
25
25
if verbose :
26
- print ("Missing modules flake8 or flake8-import-order. Please be"
27
- " sure to install these python packages before linting." )
26
+ print ("""
27
+ The flake8 and flake8-import-order Python packages are required for linting,
28
+ but these were not found on your system.
29
+
30
+ You can install these using:
31
+
32
+ python -m pip install flake8
33
+ python -m pip install flake8-import-order
34
+
35
+ For more help, see http://flake8.pycqa.org.""" )
36
+
37
+ # We should be returning `flake8_result` from here. However,
38
+ # some Python files lint themselves using embedded doctests,
39
+ # which causes CI smoke tests to fail because the Linux nodes
40
+ # do not have these modules installed.
41
+
28
42
return 0
29
43
30
44
utils_directory = os .path .dirname (os .path .abspath (__file__ ))
You can’t perform that action at this time.
0 commit comments