Merge pull request swiftlang#29974 from nkcsgexi/53776566

ABIChecker: ignore accessors with forced static dispatch

Author: nkcsgexi

include/swift/AST/Decl.h

@@ -4686,6 +4686,10 @@ class AbstractStorageDecl : public ValueDecl {
   /// To ensure an accessor is always returned, use getSynthesizedAccessor().
   AccessorDecl *getOpaqueAccessor(AccessorKind kind) const;
 
+  /// Collect all opaque accessors.
+  ArrayRef<AccessorDecl*>
+    getOpaqueAccessors(llvm::SmallVectorImpl<AccessorDecl*> &scratch) const;
+
   /// Return an accessor that was written in source. Returns null if the
   /// accessor was not explicitly defined by the user.
   AccessorDecl *getParsedAccessor(AccessorKind kind) const;

lib/AST/Decl.cpp

@@ -2225,6 +2225,12 @@ AccessorDecl *AbstractStorageDecl::getOpaqueAccessor(AccessorKind kind) const {
   return getSynthesizedAccessor(kind);
 }
 
+ArrayRef<AccessorDecl*> AbstractStorageDecl::getOpaqueAccessors(
+    llvm::SmallVectorImpl<AccessorDecl*> &scratch) const {
+  visitOpaqueAccessors([&](AccessorDecl *D) { scratch.push_back(D); });
+  return scratch;
+}
+
 bool AbstractStorageDecl::hasParsedAccessors() const {
   for (auto *accessor : getAllAccessors())
     if (!accessor->isImplicit())

test/api-digester/Outputs/Cake-abi.txt

@@ -12,7 +12,6 @@ cake: Accessor RemoveSetters.Value.Modify() has been removed
 cake: Accessor RemoveSetters.Value.Set() has been removed
 cake: Accessor RemoveSetters.subscript(_:).Modify() has been removed
 cake: Accessor RemoveSetters.subscript(_:).Set() has been removed
-cake: Accessor fixedLayoutStruct.height.Read() has been removed
 cake: AssociatedType RequiementChanges.removedType has been removed
 cake: Class C3 has been removed
 cake: Constructor Somestruct2.init(_:) has been removed

test/api-digester/Outputs/stability-stdlib-abi.asserts.additional.swift.expected

@@ -1,7 +1 @@
-Func _collectReferencesInsideObject(_:) is a new API without @available attribute
-Func _loadDestroyTLSCounter() is a new API without @available attribute
-Protocol _RuntimeFunctionCountersStats is a new API without @available attribute
-Struct _GlobalRuntimeFunctionCountersState is a new API without @available attribute
-Struct _ObjectRuntimeFunctionCountersState is a new API without @available attribute
-Struct _RuntimeFunctionCounters is a new API without @available attribute
-Func _measureRuntimeFunctionCountersDiffs(objects:_:) is a new API without @available attribute
+

test/api-digester/Outputs/stability-stdlib-abi.without.asserts.swift.expected

@@ -1,2 +1 @@
-Class _SwiftNSMutableArray is a new API without @available attribute
-Class _SwiftNativeNSMutableArray is a new API without @available attribute
+