Minor cleanup of initial swiftdt work.

Author: mikeash

include/swift/Demangling/ManglingUtils.h

@@ -191,8 +191,8 @@ void mangleIdentifier(Mangler &M, StringRef ident) {
       // of the identifier - that's why we added the dummy-word).
       // The first thing: we add the encoded sub-string length.
       M.Buffer << (Repl.StringPos - Pos);
-//       assert(!isDigit(ident[Pos]) &&
-//              "first char of sub-string may not be a digit");
+      assert(!isDigit(ident[Pos]) &&
+             "first char of sub-string may not be a digit");
       do {
         // Update the start position of new added words, so that they refer to
         // the begin of the whole mangled Buffer.

include/swift/Reflection/ReflectionContext.h

@@ -773,27 +773,6 @@ class ReflectionContext
     }
   }
 
-  StoredSignedPointer getTypeContextDescriptor(const TargetMetadata<Runtime> *Metadata) const {
-    switch (Metadata->getKind()) {
-    case MetadataKind::Class: {
-      const auto cls = static_cast<const TargetClassMetadata<Runtime> *>(Metadata);
-      if (!cls->isTypeMetadata())
-        return {};
-      return cls->getDescriptionAsSignedPointer();
-    }
-    case MetadataKind::Struct:
-    case MetadataKind::Enum:
-    case MetadataKind::Optional:
-      return static_cast<const TargetValueMetadata<Runtime> *>(Metadata)
-          ->Description;
-    case MetadataKind::ForeignClass:
-      return static_cast<const TargetForeignClassMetadata<Runtime> *>(Metadata)
-          ->Description;
-    default:
-      return {};
-    }
-  }
-
   /// Iterate the protocol conformance cache tree rooted at NodePtr, calling
   /// Call with the type and protocol in each node.
   void iterateConformanceTree(StoredPointer NodePtr,

include/swift/SwiftRemoteMirror/module.modulemap

@@ -1,4 +1,4 @@
 module SwiftRemoteMirror {
   header "SwiftRemoteMirror.h"
   export *
-}
+}