Improve assert

elsh · elsh · commit 8a6ee3730151 · 2021-09-24T14:54:24.000-07:00
diff --git a/lib/Frontend/ArgsToFrontendOptionsConverter.cpp b/lib/Frontend/ArgsToFrontendOptionsConverter.cpp
@@ -560,8 +560,7 @@ bool ArgsToFrontendOptionsConverter::computeModuleAliases() {
 }
 
 bool ArgsToFrontendOptionsConverter::computeModuleName() {
-  // Module alias (if any) should be computed after module name is computed
-  assert(Opts.ModuleAliasMap.empty());
+  assert(Opts.ModuleAliasMap.empty() && "Module name must be computed before computing module aliases");
 
   const Arg *A = Args.getLastArg(options::OPT_module_name);
   if (A) {

Original file line number	Diff line number	Diff line change
`@@ -560,8 +560,7 @@ bool ArgsToFrontendOptionsConverter::computeModuleAliases() {`
`560`	`560`	`}`
`561`	`561`
`562`	`562`	`bool ArgsToFrontendOptionsConverter::computeModuleName() {`
`563`		`- // Module alias (if any) should be computed after module name is computed`
`564`		`- assert(Opts.ModuleAliasMap.empty());`
	`563`	`+ assert(Opts.ModuleAliasMap.empty() && "Module name must be computed before computing module aliases");`
`565`	`564`
`566`	`565`	`const Arg *A = Args.getLastArg(options::OPT_module_name);`
`567`	`566`	`if (A) {`