[Localization] Adjust types associated with reader/writer info

Add more usages of `offset_type` where appropriate and change
buffer type to `const unsigned char *`.

Author: xedin

include/swift/AST/LocalizationFormat.h

@@ -45,9 +45,9 @@ class LocalizationWriterInfo {
 
   hash_value_type ComputeHash(key_type_ref key) { return llvm::djbHash(key); }
 
-  std::pair<unsigned, unsigned> EmitKeyDataLength(llvm::raw_ostream &out,
-                                                  key_type_ref key,
-                                                  data_type_ref data) {
+  std::pair<offset_type, offset_type> EmitKeyDataLength(llvm::raw_ostream &out,
+                                                        key_type_ref key,
+                                                        data_type_ref data) {
     offset_type keyLength = static_cast<offset_type>(key.size());
     offset_type dataLength = static_cast<offset_type>(data.size());
     endian::write<offset_type>(out, keyLength, little);
@@ -85,19 +85,20 @@ class LocalizationReaderInfo {
     return llvm::djbHash(key);
   }
 
-  static std::pair<unsigned, unsigned> ReadKeyDataLength(const uint8_t *&data) {
+  static std::pair<offset_type, offset_type>
+  ReadKeyDataLength(const unsigned char *&data) {
     offset_type keyLength =
         endian::readNext<offset_type, little, unaligned>(data);
     offset_type dataLength =
         endian::readNext<offset_type, little, unaligned>(data);
     return {keyLength, dataLength};
   }
 
-  internal_key_type ReadKey(const uint8_t *data, offset_type length) {
+  internal_key_type ReadKey(const unsigned char *data, offset_type length) {
     return internal_key_type((const char *)data, length);
   }
 
-  data_type ReadData(llvm::StringRef Key, const uint8_t *data,
+  data_type ReadData(llvm::StringRef Key, const unsigned char *data,
                      offset_type length) {
     return data_type((const char *)data, length);
   }

lib/AST/LocalizationFormat.cpp

@@ -101,7 +101,8 @@ bool SerializedLocalizationWriter::emit(llvm::StringRef filePath) {
 SerializedLocalizationProducer::SerializedLocalizationProducer(
     std::unique_ptr<llvm::MemoryBuffer> buffer)
     : Buffer(std::move(buffer)) {
-  auto base = reinterpret_cast<const uint8_t *>(Buffer.get()->getBufferStart());
+  auto base =
+      reinterpret_cast<const unsigned char *>(Buffer.get()->getBufferStart());
   auto tableOffset = endian::read<offset_type>(base, little);
   SerializedTable.reset(SerializedLocalizationTable::Create(
       base + tableOffset, base + sizeof(offset_type), base));

localization/CMakeLists.txt

@@ -8,7 +8,10 @@ add_custom_command(
 
 add_custom_command(
   TARGET diagnostic-translation-database
-  COMMAND swift-serialize-diagnostics --input-file-path="${SWIFT_BINARY_DIR}/share/swift/diagnostics/en.yaml"  --output-directory="${SWIFT_BINARY_DIR}/share/swift/diagnostics/")
+  WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
+  COMMAND swift-serialize-diagnostics
+    --input-file-path diagnostics/en.yaml
+    --output-directory ${SWIFT_BINARY_DIR}/share/swift/diagnostics)
 
 add_dependencies(swift-frontend diagnostic-translation-database)