SmallProjectionPath: replace hasNoClassProjection with mayHaveClassProjection

It's less confusing.
NFC

Author: eeckstein

SwiftCompilerSources/Sources/Optimizer/Utilities/EscapeUtils.swift

@@ -382,7 +382,7 @@ fileprivate struct EscapeWalker<V: EscapeVisitor> : ValueDefUseWalker,
 
         // Class references, which are directly located in the array elements cannot escape,
         // because those are passed as `self` to their deinits - and `self` cannot escape in a deinit.
-        if path.projectionPath.hasNoClassProjection {
+        if !path.projectionPath.mayHaveClassProjection {
           return .continueWalk
         }
         return isEscaping
@@ -818,7 +818,7 @@ fileprivate struct EscapeWalker<V: EscapeVisitor> : ValueDefUseWalker,
   private func followLoads(at path: SmallProjectionPath) -> Bool {
     return visitor.followLoads ||
            // When part of a class field we have to follow loads.
-           !path.hasNoClassProjection
+           path.mayHaveClassProjection
   }
 
   private func pathForArgumentEscapeChecking(_ path: SmallProjectionPath) -> SmallProjectionPath {

SwiftCompilerSources/Sources/SIL/Effects.swift

@@ -499,7 +499,7 @@ public struct SideEffects : CustomStringConvertible, NoReflectionChildren {
       case .directGuaranteed:
         // Note that `directGuaranteed` still has a "destroy" effect, because an object stored in
         // a class property could be destroyed.
-        if argument.path.hasNoClassProjection {
+        if !argument.path.mayHaveClassProjection {
           result.ownership.destroy = false
         }
         fallthrough

SwiftCompilerSources/Sources/SIL/SmallProjectionPath.swift

@@ -244,15 +244,6 @@ public struct SmallProjectionPath : Hashable, CustomStringConvertible, NoReflect
     }
   }
 
-  /// Returns true if the path does not have any class projections.
-  /// For example:
-  /// returns true for `v**`
-  /// returns false for `c0`
-  /// returns false for `**` (because '**' can have any number of class projections)
-  public var hasNoClassProjection: Bool {
-    return matches(pattern: Self(.anyValueFields))
-  }
-
   /// Returns true if the path has at least one class projection.
   /// For example:
   /// returns false for `v**`
@@ -268,6 +259,15 @@ public struct SmallProjectionPath : Hashable, CustomStringConvertible, NoReflect
     }
   }
 
+  /// Returns true if the path may have a class projection.
+  /// For example:
+  /// returns false for `v**`
+  /// returns true for `c0`
+  /// returns true for `**` (because '**' can have any number of class projections)
+  public var mayHaveClassProjection: Bool {
+    return !matches(pattern: Self(.anyValueFields))
+  }
+
   /// Pops all value field components from the beginning of the path.
   /// For example:
   ///    `s0.e2.3.c4.s1` -> `c4.s1`
@@ -679,17 +679,18 @@ extension SmallProjectionPath {
     }
 
     func predicates() {
-      testPredicate("v**", \.hasNoClassProjection, expect: true)
-      testPredicate("c0",  \.hasNoClassProjection, expect: false)
-      testPredicate("1",   \.hasNoClassProjection, expect: true)
-      testPredicate("**",  \.hasNoClassProjection, expect: false)
-
       testPredicate("v**",           \.hasClassProjection, expect: false)
       testPredicate("v**.c0.s1.v**", \.hasClassProjection, expect: true)
       testPredicate("c0.**",         \.hasClassProjection, expect: true)
       testPredicate("c0.c1",         \.hasClassProjection, expect: true)
       testPredicate("ct",            \.hasClassProjection, expect: true)
       testPredicate("s0",            \.hasClassProjection, expect: false)
+
+      testPredicate("v**", \.mayHaveClassProjection, expect: false)
+      testPredicate("c0",  \.mayHaveClassProjection, expect: true)
+      testPredicate("1",   \.mayHaveClassProjection, expect: false)
+      testPredicate("**",  \.mayHaveClassProjection, expect: true)
+
     }
 
     func testPredicate(_ pathStr: String, _ property: (SmallProjectionPath) -> Bool, expect: Bool) {