Add @Always(__inline) to _parseInteger(UnsafeBufferPointer<UInt8>, Int)

meg-gupta · meg-gupta · commit 8fafdd1148bc · 2023-08-18T14:32:14.000-07:00
Integer parsing seems to be very sensitive to inlining. With simplifycfg, _parseInteger function gets bigger and ends up not being inlined causing significant performance regression in the integer parsing benchmarks. Add @Always(__inline) to recover the performance.
diff --git a/stdlib/public/core/IntegerParsing.swift b/stdlib/public/core/IntegerParsing.swift
@@ -57,6 +57,7 @@ internal func _parseIntegerDigits<Result: FixedWidthInteger>(
 }
 
 @_alwaysEmitIntoClient
+@inline(__always)
 internal func _parseInteger<Result: FixedWidthInteger>(
   ascii codeUnits: UnsafeBufferPointer<UInt8>, radix: Int
 ) -> Result? {

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,7 @@ internal func _parseIntegerDigits<Result: FixedWidthInteger>(`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`@_alwaysEmitIntoClient`
	`60`	`+@inline(__always)`
`60`	`61`	`internal func _parseInteger<Result: FixedWidthInteger>(`
`61`	`62`	`ascii codeUnits: UnsafeBufferPointer<UInt8>, radix: Int`
`62`	`63`	`) -> Result? {`