Skip to content

Commit 90eaff0

Browse files
committed
libswift: on macOS, make the default build mode bootstrapping-with-hostlibs
This is much faster than the full "bootstrapping" mode. On linux, the default stays "bootstrapping", because "bootstrapping-with-hostlibs" is not supported. In CI: * Build two presets with "bootstrapping", so that this mode is tested on macOS at least on some bots. * Do the macOS smoke test also with "bootstrapping-with-hostlibs". It only adds ~30 sec compared to "hosttools" which was used previously.
1 parent 3c40ea5 commit 90eaff0

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

utils/build-presets.ini

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,9 @@ skip-test-ios-host
192192
skip-test-tvos-host
193193
skip-test-watchos-host
194194

195-
libswift=bootstrapping-with-hostlibs
195+
# Test the full bootstrapping on at least some jobs
196+
# (the default is bootstrapping-with-hostlibs)
197+
libswift=bootstrapping
196198

197199
[preset: buildbot,tools=RA,stdlib=RD,test=non_executable]
198200
mixin-preset=
@@ -216,7 +218,9 @@ skip-test-tvos-host
216218
skip-test-watchos-host
217219
check-incremental-compilation
218220

219-
libswift=bootstrapping-with-hostlibs
221+
# Test the full bootstrapping on at least some jobs
222+
# (the default is bootstrapping-with-hostlibs)
223+
libswift=bootstrapping
220224

221225
[preset: buildbot,tools=R,stdlib=RD,test=non_executable]
222226
mixin-preset=
@@ -653,9 +657,6 @@ skip-build-benchmarks
653657
# Skip playground tests
654658
skip-test-playgroundsupport
655659

656-
# Don't do bootstrapping to speed up the build
657-
libswift=hosttools
658-
659660
[preset: buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx,flto]
660661
mixin-preset=buildbot_incremental,tools=RA,stdlib=RD,smoketest=macosx
661662
build-subdir=buildbot_incremental
@@ -1563,9 +1564,6 @@ build-swift-stdlib-unittest-extra
15631564

15641565
libcxx
15651566

1566-
# Don't do bootstrapping to speed up the build
1567-
libswift=hosttools
1568-
15691567
# Build llbuild & swiftpm here
15701568
llbuild
15711569
swiftpm

utils/build-script-impl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,11 @@ function to_libswift_buildmode() {
362362
echo "OFF"
363363
;;
364364
true | TRUE | 1 | "")
365-
echo "BOOTSTRAPPING"
365+
if [[ "$(uname -s)" == "Darwin" ]] ; then
366+
echo "BOOTSTRAPPING-WITH-HOSTLIBS"
367+
else
368+
echo "BOOTSTRAPPING"
369+
fi
366370
;;
367371
*)
368372
echo `toupper $1`

utils/build_swift/build_swift/driver_arguments.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -546,8 +546,6 @@ def create_argument_parser():
546546

547547
option('--libswift', store('libswift_mode'),
548548
choices=['off', 'hosttools', 'bootstrapping', 'bootstrapping-with-hostlibs'],
549-
const='hosttools',
550-
default=None,
551549
help='The libswift build mode. For details see libswift/README.md')
552550

553551
# -------------------------------------------------------------------------

0 commit comments

Comments
 (0)