[NFC] SIL: Extracted has "any" move-only wrapping.

This predicate is used in several places.

Author: nate-chandler

include/swift/SIL/SILType.h

@@ -857,6 +857,11 @@ class SILType {
   /// requires a SILFunction * and is specialized.
   SILType removingMoveOnlyWrapperFromBoxedType(const SILFunction *fn);
 
+  /// Whether there's a direct wrapper or a wrapper inside a box.
+  bool hasAnyMoveOnlyWrapping(const SILFunction *fn) {
+    return isMoveOnlyWrapped() || isBoxedMoveOnlyWrappedType(fn);
+  }
+
   /// Returns a SILType with any archetypes mapped out of context.
   SILType mapTypeOutOfContext() const;
 

include/swift/SIL/SILValue.h

@@ -597,7 +597,7 @@ class ValueBase : public SILNode, public SILAllocated<ValueBase> {
   /// NOTE: Please do not use this directly! It is only meant to be used by the
   /// optimizer pass: SILMoveOnlyWrappedTypeEliminator.
   bool unsafelyEliminateMoveOnlyWrapper(const SILFunction *fn) {
-    if (!Type.isMoveOnlyWrapped() && !Type.isBoxedMoveOnlyWrappedType(fn))
+    if (!Type.hasAnyMoveOnlyWrapping(fn))
       return false;
     if (Type.isMoveOnlyWrapped()) {
       Type = Type.removingMoveOnlyWrapper();

lib/SILOptimizer/Mandatory/MoveOnlyWrappedTypeEliminator.cpp

@@ -301,8 +301,7 @@ bool SILMoveOnlyWrappedTypeEliminator::process() {
 
   for (auto &bb : *fn) {
     for (auto *arg : bb.getArguments()) {
-      if (!arg->getType().isMoveOnlyWrapped() &&
-          !arg->getType().isBoxedMoveOnlyWrappedType(fn))
+      if (!arg->getType().hasAnyMoveOnlyWrapping(fn))
         continue;
 
       // If we are looking at trivial only, skip non-trivial function args.
@@ -323,8 +322,7 @@ bool SILMoveOnlyWrappedTypeEliminator::process() {
 
     for (auto &ii : bb) {
       for (SILValue v : ii.getResults()) {
-        if (!v->getType().isMoveOnlyWrapped() &&
-            !v->getType().isBoxedMoveOnlyWrappedType(fn))
+        if (!v->getType().hasAnyMoveOnlyWrapping(fn))
           continue;
 
         if (trivialOnly &&