Skip to content

Commit 929c693

Browse files
committed
[nfc] adding FIXME about simplifying concurrency typechecking code.
The design of things are currently a bit in flux, so until that settles down, I thought it would be better to just log this as a possible clean-up in the future.
1 parent 93ffb88 commit 929c693

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

lib/Sema/TypeCheckConcurrency.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -542,6 +542,11 @@ ActorIsolationRestriction ActorIsolationRestriction::forDeclaration(
542542

543543
// A function that provides an asynchronous context has no restrictions
544544
// on its access.
545+
//
546+
// FIXME: technically, synchronous functions are allowed to be cross-actor.
547+
// The call-sites are just conditionally async based on where they appear
548+
// (outside or inside the actor). This suggests that the implicitly-async
549+
// concept could be merged into the CrossActorSelf concept.
545550
if (auto func = dyn_cast<AbstractFunctionDecl>(decl)) {
546551
if (func->isAsyncContext())
547552
isAccessibleAcrossActors = true;

0 commit comments

Comments
 (0)