Skip to content

Commit 9354a93

Browse files
authored
Merge pull request swiftlang#9208 from gottesmm/more_small_gardening
2 parents 5c52400 + 112f344 commit 9354a93

File tree

5 files changed

+46
-34
lines changed

5 files changed

+46
-34
lines changed

stdlib/public/runtime/ImageInspection.h

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,27 +9,30 @@
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
12-
//
13-
// This file includes routines that extract metadata from executable and
14-
// dynamic library image files generated by the Swift compiler. The
15-
// concrete implementations vary greatly by platform.
16-
//
12+
///
13+
/// \file
14+
///
15+
/// This file includes routines that extract metadata from executable and
16+
/// dynamic library image files generated by the Swift compiler. The concrete
17+
/// implementations vary greatly by platform.
18+
///
1719
//===----------------------------------------------------------------------===//
1820

19-
#ifndef SWIFT_RUNTIME_IMAGE_INSPECTION_H
20-
#define SWIFT_RUNTIME_IMAGE_INSPECTION_H
21+
#ifndef SWIFT_RUNTIME_IMAGEINSPECTION_H
22+
#define SWIFT_RUNTIME_IMAGEINSPECTION_H
2123

2224
#include "ImageInspectionELF.h"
2325
#include <cstdint>
2426

2527
namespace swift {
26-
// This is a platform independent version of Dl_info from dlfcn.h
27-
struct SymbolInfo {
28-
const char *fileName;
29-
void *baseAddress;
30-
const char *symbolName;
31-
void *symbolAddress;
32-
};
28+
29+
/// This is a platform independent version of Dl_info from dlfcn.h
30+
struct SymbolInfo {
31+
const char *fileName;
32+
void *baseAddress;
33+
const char *symbolName;
34+
void *symbolAddress;
35+
};
3336

3437
/// Load the metadata from the image necessary to find a type's
3538
/// protocol conformance.
@@ -46,6 +49,7 @@ void addImageTypeMetadataRecordBlockCallback(const void *start,
4649
uintptr_t size);
4750

4851
int lookupSymbol(const void *address, SymbolInfo *info);
52+
4953
} // end namespace swift
5054

51-
#endif // SWIFT_RUNTIME_IMAGE_INSPECTION_H
55+
#endif

stdlib/public/runtime/ImageInspectionELF.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
12-
//
13-
// This file includes routines that interact with ld*.so on ELF-based platforms
14-
// to extract runtime metadata embedded in dynamically linked ELF images
15-
// generated by the Swift compiler.
16-
//
12+
///
13+
/// \file
14+
///
15+
/// This file includes routines that interact with ld*.so on ELF-based platforms
16+
/// to extract runtime metadata embedded in dynamically linked ELF images
17+
/// generated by the Swift compiler.
18+
///
1719
//===----------------------------------------------------------------------===//
1820

1921
#if defined(__ELF__) || defined(__ANDROID__)

stdlib/public/runtime/ImageInspectionELF.h

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,15 @@
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
12-
//
13-
// ELF specific image inspection routines.
14-
//
12+
///
13+
/// \file
14+
///
15+
/// ELF specific image inspection routines.
16+
///
1517
//===----------------------------------------------------------------------===//
1618

17-
#ifndef SWIFT_RUNTIME_IMAGE_INSPECTION_ELF_H
18-
#define SWIFT_RUNTIME_IMAGE_INSPECTION_ELF_H
19+
#ifndef SWIFT_RUNTIME_IMAGEINSPECTIONELF_H
20+
#define SWIFT_RUNTIME_IMAGEINSPECTIONELF_H
1921

2022
#if defined(__ELF__) || defined(__ANDROID__)
2123

stdlib/public/runtime/ImageInspectionInit.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,12 @@
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
12-
//
13-
// This file along with swift_sections.S is prepended to each shared library
14-
// on an ELF target which contains protocol and metadata sections.
15-
//
12+
///
13+
/// \file
14+
///
15+
/// This file along with swift_sections.S is prepended to each shared library on
16+
/// an ELF target which contains protocol and metadata sections.
17+
///
1618
//===----------------------------------------------------------------------===//
1719

1820
#if defined(__ELF__) || defined(__ANDROID__)

stdlib/public/runtime/ImageInspectionMachO.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@
99
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
1010
//
1111
//===----------------------------------------------------------------------===//
12-
//
13-
// This file includes routines that interact with dyld on Mach-O-based platforms
14-
// to extract runtime metadata embedded in images generated by the Swift
15-
// compiler.
16-
//
12+
///
13+
/// \file
14+
///
15+
/// This file includes routines that interact with dyld on Mach-O-based
16+
/// platforms to extract runtime metadata embedded in images generated by the
17+
/// Swift compiler.
18+
///
1719
//===----------------------------------------------------------------------===//
1820

1921
#if defined(__APPLE__) && defined(__MACH__)

0 commit comments

Comments
 (0)