Merge pull request swiftlang#36543 from slavapestov/for-try-await-rdar75274975

Sema: Fix effect checking bug with 'for try await'

Author: slavapestov

lib/Sema/TypeCheckEffects.cpp

@@ -2598,13 +2598,21 @@ class CheckEffectsCoverage : public EffectsHandlingWalker<CheckEffectsCoverage>
       auto classification = classifier.classifyConformance(
           S->getSequenceConformance(), EffectKind::Throws);
       auto throwsKind = classification.getConditionalKind(EffectKind::Throws);
+
+      if (throwsKind != ConditionalEffectKind::None)
+        Flags.set(ContextFlags::HasAnyThrowSite);
+
       if (!CurContext.handlesThrows(throwsKind))
         CurContext.diagnoseUnhandledThrowStmt(Ctx.Diags, S);
     }
 
     auto classification = classifier.classifyConformance(
         S->getSequenceConformance(), EffectKind::Async);
     auto asyncKind = classification.getConditionalKind(EffectKind::Async);
+
+    if (asyncKind != ConditionalEffectKind::None)
+      Flags.set(ContextFlags::HasAnyAsyncSite);
+
     if (!CurContext.handlesAsync(asyncKind))
       CurContext.diagnoseUnhandledAsyncSite(Ctx.Diags, S, Context::Unspecified);
 

test/Concurrency/async_sequence_syntax.swift

@@ -54,4 +54,13 @@ func doubleDiagCheckConcrete(_ seq: ThrowingAsyncSequence) async {
   var it = seq.makeAsyncIterator()
   // expected-error@+1{{call can throw, but it is not marked with 'try' and the error is not handled}}
   let _ = await it.next()
-}
+}
+
+// rdar://75274975
+func forAwaitInsideDoCatch<Source: AsyncSequence>(_ source: Source) async {
+  do {
+    for try await item in source {
+      print(item)
+    }
+  } catch {} // no-warning
+}