Better message diagnostics for inout @escaping closure

Author: iMostfa

include/swift/AST/DiagnosticsSema.def

@@ -4015,6 +4015,9 @@ ERROR(autoclosure_function_input_nonunit,none,
 ERROR(escaping_non_function_parameter,none,
       "@escaping attribute may only be used in function parameter position", ())
 
+ERROR(escaping_inout_parameter,none,
+      "inout expression is implicitly escaping", ())
+
 ERROR(escaping_optional_type_argument, none,
       "closure is already escaping in optional type argument", ())
 

lib/Sema/TypeCheckType.cpp

@@ -3393,6 +3393,10 @@ TypeResolver::resolveAttributedType(TypeRepr *repr, TypeResolutionOptions option
           diagnoseInvalid(repr, repr->getLoc(),
                           diag::escaping_optional_type_argument)
               .fixItRemove(attrRange);
+        } else if (options.is(TypeResolverContext::InoutFunctionInput)) {
+          diagnoseInvalid(repr, repr->getLoc(),
+                          diag::escaping_inout_parameter)
+              .fixItRemove(attrRange);
         } else {
           diagnoseInvalid(repr, loc, diag::escaping_non_function_parameter)
               .fixItRemove(attrRange);

test/attr/escaping_inout_arugment.swift

@@ -0,0 +1,7 @@
+// RUN: %target-typecheck-verify-swift
+
+let _: (_ v: inout @escaping () -> Void) -> ()
+// expected-error@-1 {{inout expression is implicitly escaping}}{{20-30=}}
+
+func m(v: inout @escaping () -> Void) {}
+// expected-error@-1 {{inout expression is implicitly escaping}}{{17-27=}}