Sema: Remove some dead code from DeclChecker::visitPatternBindingDecl()

Author: slavapestov

lib/Sema/TypeCheckDecl.cpp

@@ -2233,9 +2233,6 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
   }
 
   void visitPatternBindingDecl(PatternBindingDecl *PBD) {
-    if (PBD->isBeingValidated())
-      return;
-
     // Check all the pattern/init pairs in the PBD.
     validatePatternBindingEntries(TC, PBD);
 
@@ -2252,10 +2249,6 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
           PBD->getPattern(i)->hasStorage() &&
           !PBD->getPattern(i)->getType()->hasError()) {
 
-        // If we have a type-adjusting attribute (like ownership), apply it now.
-        if (auto var = PBD->getSingleVar())
-          TC.checkTypeModifyingDeclAttributes(var);
-
         // Decide whether we should suppress default initialization.
         //
         // Note: Swift 4 had a bug where properties with a desugared optional
@@ -2282,7 +2275,6 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
           // If we got a default initializer, install it and re-type-check it
           // to make sure it is properly coerced to the pattern type.
           PBD->setInit(i, defaultInit);
-          TC.typeCheckPatternBinding(PBD, i);
         }
       }
     }